Ported JIB implementation #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/portJIB
branch
from
d1db55c
to
78efb89
Compare
|
Just to establish my point, I've refactored it a bit while porting. It would look like this when merged: |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
============================================
- Coverage 23.79% 23.56% -0.24%
Complexity 1296 1296
============================================
Files 324 326 +2
Lines 17403 17576 +173
Branches 2671 2694 +23
============================================
Hits 4141 4141
- Misses 12786 12959 +173
Partials 476 476
Continue to review full report at Codecov.
|
…r heath check… Ported PR fabric8io/fabric8-maven-plugin#1756
…ividual template files (which will be resolved by helm mojo) + HELM mode does not support parameters without value Ported PR fabric8io/fabric8-maven-plugin#1713 Ported PR fabric8io/fabric8-maven-plugin#1733
+ spring-boot generator can not handle multi-profile configration Ported PR fabric8io/fabric8-maven-plugin#1745 Ported PR fabric8io/fabric8-maven-plugin#1746
…o/path annotation Ported PR fabric8io/fabric8-maven-plugin#1707
rohanKanojia
force-pushed
the
pr/portJIB
branch
from
78efb89
to
6ba765f
Compare
This pull request shall port the following PRs: fabric8io/fabric8-maven-plugin#1675 fabric8io/fabric8-maven-plugin#1734 fabric8io/fabric8-maven-plugin#1739 fabric8io/fabric8-maven-plugin#1740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request shall port the following PRs:
fabric8io/fabric8-maven-plugin#1675
fabric8io/fabric8-maven-plugin#1734
fabric8io/fabric8-maven-plugin#1739
fabric8io/fabric8-maven-plugin#1740