[0.37.0] Ensure _suppressEA option field is initialized to NULL #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzongaro
requested review from
jdmpapin
and removed request for
mstoodle and
0xdaryl
|
Devin @jdmpapin, may I ask you to merge this change to the v0.37.0-release branch as well? Sorry for the bother! |
|
I just realized that this pull request contains a version of the change where the assignment to |
The _suppressEA field in OMR::Options was not initialized to NULL in the OMR::Options::init method, which means it could contain garbage that will cause intermittent crashes if the field is dereferenced.
hzongaro
force-pushed
the
initialize-suppressEA-option-v0.37.0
branch
from
dd6fd22
to
ae7ff29
Compare
jdmpapin
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_suppressEAfield inOMR::Optionswas not initialized toNULLin theOMR::Options::initmethod, which means it could contain garbage that will cause intermittent crashes if the field is dereferenced.Fixes eclipse-openj9/openj9#16834
Delivers OMR pull request eclipse/omr#6926 to the
v0.37.0-releasebranch.