Ensure _suppressEA option field is initialized to NULL #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _suppressEA field in OMR::Options was not initialized to NULL in the OMR::Options::init method, which means it could contain garbage that will cause intermittent crashes if the field is dereferenced.
|
Devin @jdmpapin, may I ask you to review this change? |
|
Jenkins build all |
hzongaro
requested review from
jdmpapin
and removed request for
mstoodle and
0xdaryl
jdmpapin
approved these changes
Mar 15, 2023
|
The only failure is in the eclipse.omr Mac build, and that's #6924 |
This was referenced Mar 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_suppressEAfield inOMR::Optionswas not initialized toNULLin theOMR::Options::initmethod, which means it could contain garbage that will cause intermittent crashes if the field is dereferenced.Fixes eclipse-openj9/openj9#16834