Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git] "Decorate" files ignored by Git #1564

Open
kittaakos opened this issue Mar 21, 2018 · 8 comments
Open

[git] "Decorate" files ignored by Git #1564

kittaakos opened this issue Mar 21, 2018 · 8 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git navigator issues related to the navigator/explorer

Comments

@kittaakos
Copy link
Contributor

This is supported by VSCode, Eclipse and probably other tools and IDEs as well.
Use git check-ignore -v *.
@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves git issues related to git labels Mar 21, 2018
@kittaakos kittaakos self-assigned this Mar 21, 2018
kittaakos added a commit that referenced this issue Mar 30, 2018
@kittaakos
GH-1564: Made inital changes to decorate Git ignored resources.
c45b72e 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Apr 1, 2018
@kittaakos
GH-1564: Switched from git check-ignore * to git clean -ndX.
9714dc3 
This is just the first naive implementation, that does not do caching.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Apr 1, 2018
@kittaakos
GH-1564: Made inital changes to decorate Git ignored resources.
8bf6095 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Apr 1, 2018
@kittaakos
GH-1564: Switched from git check-ignore * to git clean -ndX.
553b4ff 
This is just the first naive implementation, that does not do caching.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

desktop/dugite#178

@kittaakos kittaakos removed their assignment Oct 17, 2018
@kittaakos kittaakos mentioned this issue Feb 21, 2019
Closed
@vince-fugnitto vince-fugnitto added the navigator issues related to the navigator/explorer label Nov 19, 2019
@vince-fugnitto
Copy link
Member

I think it's a really nice feature to have (ignored folders/files are displayed differently - ex: node_modules):

Theia VS Code
Screen Shot 2019-11-19 at 3 10 52 PM Screen Shot 2019-11-19 at 3 10 22 PM

@akosyakov
Copy link
Member

Have you tried vscode built-in git extension?

@vince-fugnitto
Copy link
Member

Have you tried vscode built-in git extension?

I have but I still did not get any different decorations in the explorer :(

@akosyakov
Copy link
Member

@vince-fugnitto Try built-in extension but with #6475

@vince-fugnitto
Copy link
Member

@vince-fugnitto Try built-in extension but with #6475

I tried #6475 along with @theia/vscode-builtin-git and unfortunately it was still not decorated :(

@akosyakov akosyakov mentioned this issue Dec 9, 2019
Merged
54 tasks
@akosyakov
Copy link
Member

@vince-fugnitto debugged it a bit, indeed the plugin system does not implement decorator contract properly :( filed an issue here: #6772

@kittaakos kittaakos mentioned this issue Sep 1, 2020
Closed
@anavarre
Copy link

anavarre commented Sep 1, 2020

Just a note that it's supported with PhpStorm as well

phpstorm

@vince-fugnitto vince-fugnitto mentioned this issue Oct 7, 2020
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Jul 6, 2021
Closed
@kenneth-marut-work kenneth-marut-work mentioned this issue Jul 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git navigator issues related to the navigator/explorer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anavarre @kittaakos @akosyakov @vince-fugnitto