Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal][git] Remove the dugite dependency #4401

Closed
kittaakos opened this issue Feb 21, 2019 · 7 comments
Closed

[proposal][git] Remove the dugite dependency #4401

kittaakos opened this issue Feb 21, 2019 · 7 comments
Labels
git issues related to git proposal feature proposals (potential future features)

Comments

@kittaakos
Copy link
Contributor

  • We do not ship the executables anyway.

    • Yes, one can argue that the Git executable download script could be useful. I would recommend setting up Git once correctly on the environment, instead of downloading it per Theia backends. We should disable the Git UI is Git is not on the PATH.
  • No i18n support for the Git error parsing.

    • We cannot pars the liegt außerhalb des Repositories error message with the fatal: .+: '(.+)' is outside repository regular expression. It means, we do not handle the expected errors correctly. We would be complete if each git command would be prefixed with LC_ALL=C. (cc: @AlexTugarev)
  • No wildcard expansion support: [git] "Decorate" files ignored by Git  #1564.

    • We cannot do git check-ignore * because the wildcards are not expanded by dugite.
  • We could get rid of the env variables for

    • --no-optional-locks, and
    • the external Git path.

Thoughts?


Related: #4400

@kittaakos kittaakos added git issues related to git proposal feature proposals (potential future features) labels Feb 21, 2019
@kittaakos kittaakos self-assigned this Feb 21, 2019
@gorkem
Copy link
Contributor

gorkem commented Feb 26, 2019

What exactly is the proposal here?

@svenefftinge
Copy link
Contributor

What exactly is the proposal here?

to remove the dugite library completely.

@sunix
Copy link
Contributor

sunix commented Feb 26, 2019

What exactly is the proposal here?

to remove the dugite library completely.

Just dugite or the entire the Theia git extension ? (to be replaced with the VSCode extension)

@svenefftinge
Copy link
Contributor

This issue is just about removing the dugite library

@sunix
Copy link
Contributor

sunix commented Feb 26, 2019

We would need to replace it with something else, right ?

@kittaakos kittaakos changed the title [proposal][git] Remove dugite [proposal][git] Remove the dugite dependncy Feb 26, 2019
@kittaakos kittaakos changed the title [proposal][git] Remove the dugite dependncy [proposal][git] Remove the dugite dependency Feb 26, 2019
@gorkem
Copy link
Contributor

gorkem commented Feb 26, 2019

@svenefftinge Is there a second proposal to add something else that I am missing?

@kittaakos kittaakos removed their assignment Aug 2, 2019
@kittaakos
Copy link
Contributor Author

It seems we can live with dugite. I am closing this, please reopen if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

4 participants