-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GraalVM version to 22.0.0.2 #1159
Conversation
60906aa
to
227273f
Compare
all changes use 21.2 instead of 22 |
227273f
to
bba0b03
Compare
I've created #1173 which adopts the changes here and fixes the remaining things needed to get things building. I would have just pushed onto this branch but I think that capability only works for committers. |
Okay thanks, I can quickly adopt them into mine |
b16f103
to
f2b665f
Compare
ec4f0ec
to
aa07789
Compare
aa07789
to
ae67232
Compare
46a0792
to
375a1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change works for me. It might be a good idea to also confirm for Windows with the binary, but this is now up to date.
This GH action will be very useful in completing redhat-developer/vscode-xml#656 to work on the extension side. (ie. if we publish vsix snapshots on GH actions, we also need to publish an associated set of binaries to truly be testing everything)
@angelozerr feel free to merge this when you have time. All issues have been addressed. |
I would prefer that @fbricon merge this pr. |
80c00c4
to
c195cef
Compare
Also, make a title for the commit message. Currently it's :
which looks a bit cluttered when you do Maybe the following will look better.
|
c195cef
to
d45016f
Compare
- Update native-maven-plugin to 0.9.10 - Use setup-graalvm 5.0 GitHub Action - Use msvc-dev-cmd 1.10.0 GitHub Action
d45016f
to
ad20294
Compare
@fbricon , issues should be addressed now. Once we get this in we can further publish artifacts to the releases page. |
Updated GraalVM version used in binary verification builds to 22.0.0.2
Fixes #1158
Some changes adopted from #1173
Signed-off-by: Alexander Chen [email protected]