Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GraalVM version to 22.0.0.2 #1159

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

AlexXuChen
Copy link
Contributor

@AlexXuChen AlexXuChen commented Jan 27, 2022

Updated GraalVM version used in binary verification builds to 22.0.0.2

  • Update native-maven-plugin to 0.9.10
  • Use setup-graalvm 5.0 GitHub Action
  • Replace deprecated "graalvm-version" with "graalvm" & "java"
  • Use msvc-dev-cmd 1.10.0 GitHub Action

Fixes #1158

Some changes adopted from #1173

Signed-off-by: Alexander Chen [email protected]

@AlexXuChen AlexXuChen force-pushed the issue1158-graalvm branch 11 times, most recently from 60906aa to 227273f Compare January 27, 2022 21:20
@fbricon
Copy link
Contributor

fbricon commented Jan 28, 2022

all changes use 21.2 instead of 22

org.eclipse.lemminx/pom.xml Show resolved Hide resolved
org.eclipse.lemminx/pom.xml Outdated Show resolved Hide resolved
.github/workflows/native-image.yaml Outdated Show resolved Hide resolved
@rgrunber
Copy link
Contributor

I've created #1173 which adopts the changes here and fixes the remaining things needed to get things building. I would have just pushed onto this branch but I think that capability only works for committers.

@AlexXuChen
Copy link
Contributor Author

I've created #1173 which adopts the changes here and fixes the remaining things needed to get things building. I would have just pushed onto this branch but I think that capability only works for committers.

Okay thanks, I can quickly adopt them into mine

@AlexXuChen AlexXuChen force-pushed the issue1158-graalvm branch 5 times, most recently from b16f103 to f2b665f Compare February 11, 2022 22:55
@AlexXuChen AlexXuChen marked this pull request as ready for review February 11, 2022 23:04
@AlexXuChen AlexXuChen force-pushed the issue1158-graalvm branch 2 times, most recently from ec4f0ec to aa07789 Compare February 11, 2022 23:15
@AlexXuChen AlexXuChen force-pushed the issue1158-graalvm branch 3 times, most recently from 46a0792 to 375a1ea Compare February 17, 2022 04:43
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works for me. It might be a good idea to also confirm for Windows with the binary, but this is now up to date.

This GH action will be very useful in completing redhat-developer/vscode-xml#656 to work on the extension side. (ie. if we publish vsix snapshots on GH actions, we also need to publish an associated set of binaries to truly be testing everything)

@rgrunber
Copy link
Contributor

rgrunber commented Mar 2, 2022

@angelozerr feel free to merge this when you have time. All issues have been addressed.

@angelozerr
Copy link
Contributor

I would prefer that @fbricon merge this pr.

org.eclipse.lemminx/pom.xml Outdated Show resolved Hide resolved
@AlexXuChen AlexXuChen force-pushed the issue1158-graalvm branch 5 times, most recently from 80c00c4 to c195cef Compare March 3, 2022 14:35
@AlexXuChen AlexXuChen requested a review from fbricon March 3, 2022 15:08
@rgrunber
Copy link
Contributor

rgrunber commented Mar 3, 2022

Also, make a title for the commit message. Currently it's :

- Updated GraalVM to 22.0.0.2
- Updated native-maven-plugin to 0.9.10
- Use setup-graalvm 5.0 GitHub Action
- Use msvc-dev-cmd 1.10.0 GitHub Action

which looks a bit cluttered when you do git log --oneline.

Maybe the following will look better.

Updated GraalVM to 22.0.0.2

- Updated native-maven-plugin to 0.9.10
- Use setup-graalvm 5.0 GitHub Action
- Use msvc-dev-cmd 1.10.0 GitHub Action

- Update native-maven-plugin to 0.9.10
- Use setup-graalvm 5.0 GitHub Action
- Use msvc-dev-cmd 1.10.0 GitHub Action
@AlexXuChen AlexXuChen changed the title Updated GraalVM version to 22.0.0 Updated GraalVM version to 22.0.0.2 Mar 4, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Mar 7, 2022

@fbricon , issues should be addressed now. Once we get this in we can further publish artifacts to the releases page.

@fbricon fbricon merged commit 402f590 into eclipse:master Mar 9, 2022
@AlexXuChen AlexXuChen deleted the issue1158-graalvm branch March 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GraalVM version used in binary verification builds to x.y.z
4 participants