Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native-image GitHub action from repository #1184

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Mar 4, 2022

Create an entry under GH Releases for built artifacts.

- Triggered only when event is not a "pull_request"
- Create a tag "latest" marked as pre-release and attach latest binary
  artifacts from the source branch
- Use actions/download-artifact no-args to fetch all uploaded artifacts
  into their own folder

Signed-off-by: Roland Grunberg <[email protected]>

(this builds on top of #1159)

Remaining items :

  • Package binary checksum data into release
  • Binaries should be zipped
  • Rename binaries lemminx-${short-sha}-${platform} -> lemminx-${platform}

@rgrunber
Copy link
Contributor Author

rgrunber commented Mar 16, 2022

We can't run this under eclipse/lemminx. It needs to be done under redhat-developer/vscode-xml.

So disable binary uploading and pre-release generation.

@rgrunber rgrunber force-pushed the dev-release branch 7 times, most recently from 72b10c7 to 7a30b4c Compare April 7, 2022 01:45
- Action will be migrated to redhat-developer/vscode-xml

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber changed the title Create an entry under GH Releases for built artifacts. Remove native-image GitHub action from repository Apr 8, 2022
@rgrunber
Copy link
Contributor Author

rgrunber commented Apr 8, 2022

Re-located to https:/redhat-developer/vscode-xml/blob/master/.github/workflows/native-image.yaml so this can be merged now.

@angelozerr angelozerr merged commit 1bb8cdd into eclipse:master Apr 20, 2022
@angelozerr angelozerr added this to the 0.21.0 milestone Apr 20, 2022
@rgrunber rgrunber deleted the dev-release branch April 20, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants