Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage namespaces / prefix validation with a settings #961

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Manage namespaces / prefix validation with a settings #961

merged 1 commit into from
Jan 18, 2021

Conversation

angelozerr
Copy link
Contributor

Manage namespaces / prefix validation with a settings

Fixes #960

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

This PR requires the vscode-xml PR redhat-developer/vscode-xml#391 which defines the new settings xml.validation.namespaces.enabled

I need to write tests.

@angelozerr
Copy link
Contributor Author

Here a demo with vscode-xml:

NamespaceValidationDemo

@datho7561
Copy link
Contributor

If I set xml.validation.namespaces to either never or onNamespaceEncountered, prefix:bar is still marked as an error in the demo file:

<foo>
  <prefix:bar />
</foo>

@datho7561
Copy link
Contributor

I think the name of the setting and the options are great.

@angelozerr angelozerr force-pushed the namspaces-validation branch 3 times, most recently from 457c94f to 30feaba Compare January 18, 2021 06:46
@angelozerr
Copy link
Contributor Author

I think the name of the setting and the options are great.

Thanks fort he feedback.

I switch my PR to real PR since I push tests.

@angelozerr angelozerr marked this pull request as ready for review January 18, 2021 06:48
@angelozerr
Copy link
Contributor Author

If I set xml.validation.namespaces to either never or onNamespaceEncountered, prefix:bar is still marked as an error in the demo file:

You mean xml.validation.namespaces.enabled.

Are you sure that you are consuming LemMinx from this PR? If you are sure, could you set the settings to never, stop and restart vsocde.

@datho7561 datho7561 merged commit 5488280 into eclipse:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage namespaces / prefix validation with a settings
2 participants
@angelozerr @datho7561