Disable JitBuilder API generator tests on macOS on x86 #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Azure CI macOS nodes on x86 have a version of Python later than 3.1 installed where the `assertRegexpMatches` function has been deprecated (and replaced) in favour of `assertRegex`. Ideally, this API would be replaced with the newer version. However, some nodes on the OMR CI farm have older versions of Python installed that need to be upgraded first. Until that happens, since x86 macOS is the only platform affected, the JitBuilder API tests will be disabled on that platform only. There should be adequate test coverage on the other x86 platforms. Other alternatives considered were to sprinkle Python version checks throughout the code to guard each API usage (which is messy), or downgrading the Python version on the Azure builds. However, I believe the right path forward is to ensure all our build nodes have a consistent, modern version of Python installed. Once the build nodes are upgraded then this test will be modified to use the new API and it will be reenabled on all platforms that support it. Signed-off-by: Daryl Maier <[email protected]>
|
Jenkins build all |
mstoodle
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure CI macOS nodes on x86 have a version of Python later than 3.1
installed where the
assertRegexpMatchesfunction has been deprecated (andreplaced) in favour of
assertRegex.Ideally, this API would be replaced with the newer version. However, some
nodes on the OMR CI farm have older versions of Python installed that need to
be upgraded first.
Until that happens, since x86 macOS is the only platform affected, the
JitBuilder API tests will be disabled on that platform only. There should be
adequate test coverage on the other x86 platforms.
Other alternatives considered were to sprinkle Python version checks throughout
the code to guard each API usage (which is messy), or downgrading the Python
version on the Azure builds. However, I believe the right path forward is to
ensure all our build nodes have a consistent, modern version of Python
installed. Once the build nodes are upgraded then this test will be modified
to use the new API and it will be reenabled on all platforms that support it.