Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JitBuilder API generator tests on macOS on x86 #7347

Merged
merged 1 commit into from
May 23, 2024

Commits on May 23, 2024

  1. Disable JitBuilder API generator tests on macOS on x86

    The Azure CI macOS nodes on x86 have a version of Python later than 3.1
    installed where the `assertRegexpMatches` function has been deprecated (and
    replaced) in favour of `assertRegex`.
    
    Ideally, this API would be replaced with the newer version.  However, some
    nodes on the OMR CI farm have older versions of Python installed that need to
    be upgraded first.
    
    Until that happens, since x86 macOS is the only platform affected, the
    JitBuilder API tests will be disabled  on that platform only.  There should be
    adequate test coverage on the other x86 platforms.
    
    Other alternatives considered were to sprinkle Python version checks throughout
    the code to guard each API usage (which is messy), or downgrading the Python
    version on the Azure builds.  However, I believe the right path forward is to
    ensure all our build nodes have a consistent, modern version of Python
    installed.  Once the build nodes are upgraded then this test will be modified
    to use the new API and it will be reenabled on all platforms that support it.
    
    Signed-off-by: Daryl Maier <[email protected]>
    0xdaryl committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2d923b2 View commit details
    Browse the repository at this point in the history