Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node12 for ci #3196

Merged
merged 6 commits into from
Jul 28, 2019
Merged

chore: add node12 for ci #3196

merged 6 commits into from
Jul 28, 2019

Conversation

popomore
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore
Copy link
Member Author

11 有点问题,不合并。

@popomore popomore changed the title chore: add node11 for ci WIP: chore: add node11 for ci Nov 14, 2018
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #3196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3196   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          34      34           
  Lines         945     945           
======================================
  Hits          945     945

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a9666...e2649f2. Read the comment docs.

@popomore popomore changed the title WIP: chore: add node11 for ci chore: add node11 for ci Dec 10, 2018
@atian25
Copy link
Member

atian25 commented Mar 8, 2019

我重新触发了下,如果还不行,就提交一个空的 commit 吧

@ghost
Copy link

ghost commented Mar 8, 2019

@atian25:如果可以你来合并一下,我没有遇到这种情况……为什么 “continuous-integration/appveyor/branch — AppVeyor build failed” 会都不可以?

@atian25
Copy link
Member

atian25 commented Mar 8, 2019

Cannot set property router of # which has only a getter.

ci 上怎么出这个报错。。

@popomore
Copy link
Member Author

popomore commented Mar 8, 2019

看起来是有不兼容

@ghost ghost changed the title chore: add node11 for ci chore: add node12 for ci Apr 24, 2019
@fengmk2
Copy link
Member

fengmk2 commented Apr 24, 2019

eggjs/egg-core#211 应该是有 bug

@popomore
Copy link
Member Author

doctools 的 win 要 skip

@ghost
Copy link

ghost commented Apr 24, 2019

Hi @popomore

我本意是想让本地跑一个完整测试,这样可以避免文档编译生成时候尽快发现是否存在链接等错误。单独使用doctools是找不到的。

我很好奇一点:为什么单独就把win排出,而其它的平台不需要排除呢?听 @atian25 说会重复两次。这是为什么呢?
image

@popomore
Copy link
Member Author

应该没支持 win,这个不是测 doctools
,是测文档本身,只做功能性测试,不需要测试兼容性

@ghost
Copy link

ghost commented Apr 25, 2019

image

首先,此在Win平台测试是为了尽最大可能保证公平性,以及在本地提交时候跑一个完整的测试(包括文档的完整性)的目的,所以不是兼容性测试。

其次,Win本身我在自己的机器上已经测试通过(#3643).
现在的错误貌似不是win本身的问题,苹果和Linux也没有通过。

后来发现针对 Nodejs 12 确实存在一个path解析问题( hegemonic/requizzle#5hegemonic/requizzle#4

@popomore
Copy link
Member Author

@ghost ghost mentioned this pull request Apr 28, 2019
4 tasks
@thonatos
Copy link
Member

thonatos commented May 9, 2019

@popomore

doctools 已经兼容 Windows 平台 8 LTS 及以上版本。

popomore and others added 3 commits May 10, 2019 10:45
Since today Nodejs 11 is overdue, so change to 12 instead.
update to Nodejs 12
@thonatos
Copy link
Member

node x64 package not found

Appveyor 中 node v12 暂无 stable 版本,等 CI 有该版本后再处理。

@qingdengyue
Copy link
Contributor

node x64 package not found

Appveyor 中 node v12 暂无 stable 版本,等 CI 有该版本后再处理。

有Node 12的版本了 😄

https://www.appveyor.com/updates/

@atian25 atian25 removed the Inactive label Jul 23, 2019
@popomore
Copy link
Member Author

是不是可以合并了

@atian25 atian25 merged commit 0646169 into master Jul 28, 2019
@atian25 atian25 deleted the node11 branch July 28, 2019 02:48
popomore pushed a commit that referenced this pull request Jul 28, 2019
chore: add node12 for ci (#3196)
@fengmk2
Copy link
Member

fengmk2 commented Jul 28, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants