Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages,remove 'plugin' and validations of doc generation #3643

Merged
merged 1 commit into from Apr 23, 2019
Merged

chore: update packages,remove 'plugin' and validations of doc generation #3643

merged 1 commit into from Apr 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2019

  1. The 'plugin' folder in both 'en' and 'zh-CN' is replaced by a direct
    on-line search, so we don't need it anymore.

  2. Make the doc build do validations when running 'test/doc.test.js':
    image

  3. Update 'egg-bin' to '4.12.3'.


  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #3643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3643   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          34      34           
  Lines         943     943           
======================================
  Hits          943     943

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffb644...c73741e. Read the comment docs.

@ghost ghost changed the title doc: remove 'plugins' folder chore: update packages,remove 'plugin' and validations of doc generation Apr 23, 2019
1. The 'plugin' folder in both 'en' and 'zh-CN' is replaced by a direct
on-line search, so we don't need it anymore.

2. Make the doc build do validations when running 'test/doc.test.js'.

3. Update 'egg-bin' to '4.12.3'.
@ghost ghost requested review from popomore, dead-horse and atian25 April 23, 2019 01:50
@atian25 atian25 merged commit 7cc8aab into eggjs:master Apr 23, 2019
popomore pushed a commit that referenced this pull request Apr 23, 2019
chore: update packages,remove 'plugin' and validations of doc generation (#3643)
@ghost ghost mentioned this pull request Apr 25, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants