Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support urllib@3 #5000

Merged
merged 3 commits into from
Aug 28, 2022
Merged

feat: Support urllib@3 #5000

merged 3 commits into from
Aug 28, 2022

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 23, 2022

closes #4847

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
egg ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 1:46PM (UTC)

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 23, 2022

只支持 node >= 14 的话,终于可以使用 urllib 3 了

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 23, 2022

不会默认开启,先等 cnpmcore、短链接服务跑足够稳定,再推广。

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #5000 (e6e2769) into master (ff1850f) will decrease coverage by 0.08%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #5000      +/-   ##
==========================================
- Coverage   99.82%   99.74%   -0.09%     
==========================================
  Files          34       35       +1     
  Lines        1136     1159      +23     
  Branches      189      194       +5     
==========================================
+ Hits         1134     1156      +22     
- Misses          2        3       +1     
Impacted Files Coverage Δ
config/config.default.js 100.00% <ø> (ø)
lib/core/httpclient_next.js 95.00% <95.00%> (ø)
lib/egg.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atian25
Copy link
Member

atian25 commented Aug 23, 2022

有 api 的 break 么?想让 chair 底层换为 egg3

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 24, 2022

有 api 的 break 么?想让 chair 底层换为 egg3

useHttpClientNext=true 才会打开,只能先验证足够稳定性才能替换到 urllib3

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 28, 2022

还没做完,还需要处理 typescript,需要返回不同的定义。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Better http lib: undici
2 participants