🐛 FIX: Allow override HttpClientNext #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Sep 28, 2022
| @@ -293,7 +294,7 @@ class EggApplication extends EggCore { | |||
| get httpclient() { | |||
| if (!this[HTTPCLIENT]) { | |||
| if (this.config.httpclient.useHttpClientNext) { | |||
| this[HTTPCLIENT] = new HttpClientNext(this); | |||
| this[HTTPCLIENT] = new this.HttpClientNext(this); | |||
There was a problem hiding this comment.
这是过渡期的写法才会分开 urllib3 和 urllib2，等 4.0 发布就直接上 urllib 3 了
Codecov ReportBase: 99.68% // Head: 99.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5037 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 35 35
Lines 3532 3533 +1
Branches 523 523
=======================================
+ Hits 3521 3522 +1
Misses 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5000
Checklist
npm testpassesAffected core subsystem(s)
Description of change