[Ingest Manager] Logging to file disabled on enroll #24466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
backport
Team:Ingest Management
v7.12.0
Team:Elastic-Agent
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
reviewed
Mar 10, 2021
| // enroll is invoked either manually or from install with redirected IO | ||
| // no need to log to file | ||
| cfg.Settings.LoggingConfig.ToFiles = false | ||
| cfg.Settings.LoggingConfig.ToStderr = true |
There was a problem hiding this comment.
Nice! Does this need to be set on any other subcommands?
There was a problem hiding this comment.
no we use just install, uninstall, upgrade and reexec (on win) where we don't use logger
enroll where we use it
watcher has its own configuration
and run which is a normal state
There was a problem hiding this comment.
Thanks for the response.
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Mar 10, 2021
[Ingest Manager] Logging to file disabled on enroll (elastic#24466)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Mar 10, 2021
[Ingest Manager] Logging to file disabled on enroll (elastic#24466)
This was referenced Mar 10, 2021
michalpristas
added a commit
that referenced
this pull request
Mar 11, 2021
This was referenced Mar 15, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Mar 16, 2021
…reporting-changes * upstream/master: (23 commits) [Auditbeat] btmp offset check (elastic#24515) Clarify that the Tomcat module is for ingesting access logs (elastic#24543) [Ingest Manager] Move logging defaults to agent (elastic#24535) Update input-http-endpoint.asciidoc (elastic#24490) Fix typo in mqtt input docs (elastic#24509) [Elastic Agent] Add verification check when updating communication to Kibana. (elastic#24489) Refactor use of system.hostfs to fix cgroup metrics (elastic#24334) Add test for close.reader.after_interval to filestream input (elastic#24423) chore(ci): use beat_version instead of PR version (elastic#24446) Add syntax for multiple selector logging (elastic#24207) (elastic#24497) Update Golang to 1.15.9 (elastic#24442) [Elastic Agent] Add the ability to provide custom CA's inside of docker. (elastic#24486) Add tests for encoding settings of filestream input (elastic#24426) [Ingest Manager] Sync on rename on windows (elastic#24504) Port four Harvester tests of log input to filestream in Golang (elastic#24250) [DOCS] Restructure content for SSL settings (elastic#24342) Move example to the correct location in reference docs (elastic#24455) Add unit tests for harvester.go of input-logfile package (elastic#24107) Fix type for uwsgi.status.worker.rss field (elastic#24468) [Ingest Manager] Logging to file disabled on enroll (elastic#24466) ...
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#24474) Cherry-pick elastic#24466 to 7.12: Logging to file disabled on enroll (elastic#24474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The problem here is that enroll runs simultaneously with running service and both try to log into same file.
Although for enroll there's no need to do that as it is invoked either manually (with std output) or as executed from install command with std redirecting to a caller.
This PR makes sure to create internal logging file
elastic-agent-json.logonly in case it is really needed.Why is it important?
Fixes: #24173
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.