Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24466 to 7.x: Logging to file disabled on enroll #24473

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 10, 2021

Cherry-pick of PR #24466 to 7.x branch. Original message:

What does this PR do?

The problem here is that enroll runs simultaneously with running service and both try to log into same file.
Although for enroll there's no need to do that as it is invoked either manually (with std output) or as executed from install command with std redirecting to a caller.

This PR makes sure to create internal logging file elastic-agent-json.log only in case it is really needed.

Why is it important?

Fixes: #24173

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Ingest Manager] Logging to file disabled on enroll (elastic#24466)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 10, 2021
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24473 opened

  • Start Time: 2021-03-11T08:07:31.620+0000

  • Duration: 54 min 28 sec

  • Commit: 3949300

Test stats 🧪

Test Results
Failed 0
Passed 45985
Skipped 4982
Total 50967

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 45985
Skipped 4982
Total 50967

@michalpristas michalpristas merged commit 8b43fcc into elastic:7.x Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants