Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Oct 6, 2021

What does this PR do?

This changes the compatibility test for Filebeat modules to test with the previous released minor.

Why is it important?

To ensure backwards compatibility with the latest supported version

Related issues

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates elastic#26629
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2021

This pull request does not have a backport label. Could you fix it @adriansr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 6, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-06T17:38:30.172+0000

  • Duration: 159 min 13 sec

  • Commit: f0e3d5b

Test stats 🧪

Test Results
Failed 0
Passed 53653
Skipped 5346
Total 58999

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

kibana:
image: docker.elastic.co/kibana/kibana:7.15.0
healthcheck:
test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status | grep -q 'Looking good'"]
Copy link
Member

@andrewkroh andrewkroh Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Looking good" isn't so good anymore because the status format will change in 7.16. I recommend

test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status?v8format=true | grep -q '\"overall\":{\"level\":\"available\"'"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, also fixed snapshot-oss.yml

@adriansr adriansr changed the title Filebeat: Change compatibility test stage to test against previos minor instead of 7.11 Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 Oct 6, 2021
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh
Copy link
Member

So for master, once 7.16.0 is released this will change to that?

And for the 7.x (and 7.16) branch, this will remain as 7.15.0?

@adriansr
Copy link
Contributor Author

adriansr commented Oct 6, 2021

@andrewkroh, yes, this file will be automatically updated by the release scripts (that's a work in progress)

@adriansr adriansr added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Oct 7, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 7, 2021
@adriansr adriansr merged commit 9806f91 into elastic:master Oct 7, 2021
mergify bot pushed a commit that referenced this pull request Oct 7, 2021
…nor instead of 7.11 (#28274)

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates #26629

(cherry picked from commit 9806f91)
mergify bot pushed a commit that referenced this pull request Oct 7, 2021
…nor instead of 7.11 (#28274)

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates #26629

(cherry picked from commit 9806f91)
mergify bot pushed a commit that referenced this pull request Oct 7, 2021
…nor instead of 7.11 (#28274)

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates #26629

(cherry picked from commit 9806f91)

# Conflicts:
#	filebeat/Jenkinsfile.yml
#	testing/environments/prev-minor.yml
#	x-pack/filebeat/Jenkinsfile.yml
adriansr added a commit that referenced this pull request Oct 8, 2021
…nor instead of 7.11 (#28274) (#28307)

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates #26629

(cherry picked from commit 9806f91)

Co-authored-by: Adrian Serrano <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Oct 11, 2021
* upstream/master: (73 commits)
  Remove GCP support from Functionbeat (elastic#28253)
  Move labels and annotations under kubernetes.namespace. (elastic#27917)
  Update go release version 1.17.1 (elastic#27543)
  Osquerybeat: Runner and Fetcher unit tests (elastic#28290)
  Osquerybeat: Improve handling of osquery.autoload file, allow customizations (elastic#28289)
  seccomp: allow clone3 syscall for x86 (elastic#28117)
  packetbeat/protos/dns: don't render missing A and AAAA addresses from truncated records (elastic#28297)
  [7.x] [DOCS] Update api_key example on elasticsearch output (elastic#28288)
  [cloud][docker] use the private docker namespace (elastic#28286)
  Update aws-lambda-go library version to 1.13.3 (elastic#28236)
  Deprecate common.Float (elastic#28280)
  Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 (elastic#28274)
  x-pack/filebeat/module/threatintel/misp: add support for secondary object attribute handling (elastic#28124)
  Explicitly pass http config to doppler consumer (elastic#28277)
  processors/actions/add_fields: Do not panic if event.Fields is nil map (elastic#28219)
  Resolved timestamp for defender atp (elastic#28272)
  [Winlogbeat] Tolerate faults when Windows Event Log session is interrupted (elastic#28191)
  [elastic-agent] proxy requests to subprocesses to their metrics endpoints (elastic#28165)
  Build cloud docker images for elastic-agent (elastic#28134)
  Upgrade k8s go-client library (elastic#28228)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…nor instead of 7.11 (elastic#28274)

This changes the compatibility test for Filebeat modules to test with
the previous released minor.

Relates elastic#26629
ruflin added a commit to ruflin/beats that referenced this pull request Mar 21, 2022
In elastic#26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in elastic#28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced.

I'm opening this PR to remove this testing as it is not something we support anymore.
ruflin added a commit that referenced this pull request Mar 24, 2022
In #26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in #28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced.

I'm opening this PR to remove this testing as it is not something we support anymore.
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
In elastic#26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in elastic#28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced.

I'm opening this PR to remove this testing as it is not something we support anymore.
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
In #26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in #28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced.

I'm opening this PR to remove this testing as it is not something we support anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify ci review :Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants