-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly pass http config to doppler consumer #28277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 6, 2021
This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Oct 6, 2021
Collaborator
jsoriano
added
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
labels
Oct 6, 2021
mergify
bot
removed
the
backport-skip
Skip notification from the automated backport with mergify
label
Oct 6, 2021
jsoriano
added
test-plan
Add this PR to be manual test plan
backport-v7.15.0
Automated backport with mergify
and removed
backport-v7.15.0
Automated backport with mergify
labels
Oct 6, 2021
ChrsMark
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Explicitly pass the TLS and proxy settings to doppler consumer, don't rely on the type of the underlying transport. Fixes issue initializing the client. (cherry picked from commit 6a841cf)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Explicitly pass the TLS and proxy settings to doppler consumer, don't rely on the type of the underlying transport. Fixes issue initializing the client. (cherry picked from commit 6a841cf)
jsoriano
added a commit
that referenced
this pull request
Oct 8, 2021
#28301) Explicitly pass the TLS and proxy settings to doppler consumer, don't rely on the type of the underlying transport. Fixes issue initializing the client. (cherry picked from commit 6a841cf) Co-authored-by: Jaime Soriano Pastor <[email protected]>
jsoriano
added a commit
that referenced
this pull request
Oct 8, 2021
…er (#28302) Explicitly pass the TLS and proxy settings to doppler consumer, don't rely on the type of the underlying transport. Fixes issue initializing the client. (cherry picked from commit 6a841cf) Co-authored-by: Jaime Soriano Pastor <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 11, 2021
* upstream/master: (73 commits) Remove GCP support from Functionbeat (elastic#28253) Move labels and annotations under kubernetes.namespace. (elastic#27917) Update go release version 1.17.1 (elastic#27543) Osquerybeat: Runner and Fetcher unit tests (elastic#28290) Osquerybeat: Improve handling of osquery.autoload file, allow customizations (elastic#28289) seccomp: allow clone3 syscall for x86 (elastic#28117) packetbeat/protos/dns: don't render missing A and AAAA addresses from truncated records (elastic#28297) [7.x] [DOCS] Update api_key example on elasticsearch output (elastic#28288) [cloud][docker] use the private docker namespace (elastic#28286) Update aws-lambda-go library version to 1.13.3 (elastic#28236) Deprecate common.Float (elastic#28280) Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 (elastic#28274) x-pack/filebeat/module/threatintel/misp: add support for secondary object attribute handling (elastic#28124) Explicitly pass http config to doppler consumer (elastic#28277) processors/actions/add_fields: Do not panic if event.Fields is nil map (elastic#28219) Resolved timestamp for defender atp (elastic#28272) [Winlogbeat] Tolerate faults when Windows Event Log session is interrupted (elastic#28191) [elastic-agent] proxy requests to subprocesses to their metrics endpoints (elastic#28165) Build cloud docker images for elastic-agent (elastic#28134) Upgrade k8s go-client library (elastic#28228) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Explicitly pass the TLS and proxy settings to doppler consumer, don't rely on the type of the underlying transport. Fixes issue initializing the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
Team:Integrations
Label for the Integrations team
test-plan
Add this PR to be manual test plan
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Explicitly pass the TLS and proxy settings to doppler consumer.
Why is it important?
Fixes #28271 and makes the code more robust to avoid this kind of regressions.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Related issues
How to test this PR locally