-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze Functionbeat docs at 8.15 #2895
base: master
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon.
Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Co-authored-by: Brandon Morelli <[email protected]>
run docs-test |
@kilfoyle @bmorelli25 is this issue still relevant? |
@nimarezainia I think it's still relevant. Since Functionbeat isn't being updated we should freeze the docs (rather than keep building new versions of the Functionbeat guide), but I can't do that until the Kibana code is updated (via elastic/kibana#172909) to remove links from the UI into the docs. |
@kilfoyle its now merged. thank you. |
Set Functionbeat 'branches' to stop at 8.15
@elasticmachine run docs-build rebuild |
I've opened this PR in the Kibana docs to try and resolve the following failing docs build CI check: elastic/kibana#192491
|
Unfortunately my attempt to fix this failing CI check failed. |
@elastic/docs-build-guild Would any of you be familiar with link checking specifically for the Kibana UI links? The docs-build-pr CI gives me the following error, but I have no idea how to resolve it. Scrubbing the
|
What did you do to scrub the entry? I still see functionbeat referenced in main: https:/elastic/kibana/blob/main/packages/kbn-doc-links/src/get_doc_links.ts#L284 Assuming the code no longer references the link, then I think you just need to remove the functionbeat entries in get_doc_links.ts and probably types.ts. The docs about the link service are here: https://docs.elastic.dev/docs/kibana-doc-links (kinda minimal, but might help you) |
Implied in my comment: If the code does still include a link to the functionbeat docs, it'll need to be updated (or the link removed completely). You can do it yourself, but it might be easier to get a Kibana developer to do it. |
Thanks @dedemorton. My attempt to fix via a Kibana PR removed the line you mentioned ( https:/elastic/kibana/blob/main/packages/kbn-doc-links/src/get_doc_links.ts#L284 ) and that failed CI checks. I think I'll just open a Kibana issue for this. |
I've opened a Kibana issue to see if we can get Functionbeat scrubbed from the |
I've opened a new issue specifically for the Integrations Team, since one remaining link appears to come from a Cloudwatch tutorial that uses Functionbeat. |
Functionbeat is deprecated in favour of Elastic Serverless Forwarder. The docs are marked as deprecated, so now we just need to freeze the builds at 8.11 until the end of time.
CI checks should pass once this one is merged: elastic/kibana#172909
Rel: elastic/ingest-docs#608
Rel: #2814 (closed in favour of this PR)