-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to Functionbeat in Cloudwatch Logs description #172909
Conversation
As we want to freeze the documentation for Functionbeat (deprecation plan), we need to remove the links to Functionbeat documentation pages. Remove reference to Functionbeat in Cloudwatch Logs, by removing the "Learn More".
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@elasticmachine merge upstream |
CI is failing because {learnMoreLink} is still used in places such as
|
@kaiyan-sheng would it be possible to complete this merge please. We want to freeze the functionbeat docs and this was flagged as a dependency. thank you. |
@nimarezainia Yes sorry I was on vacation last week. Will look into it. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…tic#172909) ## Summary As we want to freeze the documentation for Functionbeat (deprecation plan), we need to remove the links to Functionbeat documentation pages. Remove reference to Functionbeat in Cloudwatch Logs, by removing the "Learn More" link and value. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https:/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https:/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]>
@kaiyan-sheng I'm sorry to re-raise this and please let me know if you're not the right person to ask. We're trying to freeze the Functionbeat documentation, but we can't do so until the links are removed from the UI. There are two additional links:
Since Functionbeat has been deprecated I think we should just remove the tutorials if that's possible. All the details for this are in this issue, but again please let me know if this isn't your area. Thanks! |
Summary
As we want to freeze the documentation for Functionbeat (deprecation plan), we need to remove the links to Functionbeat documentation pages.
Remove reference to Functionbeat in Cloudwatch Logs, by removing the "Learn More" link and value.
Checklist
Delete any items that are not applicable to this PR.
For maintainers