Rankeval: Fold template test project into main module #31203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves tests in `smoke-test-rank-eval-with-mustache` into the main ranking evaluation module by declaring that the integration testing cluster requires the `lang-mustache` plugin. This avoids having to maintain the qa project for only one basic test suite.
cbuescher
added
>test
|
Pinging @elastic/es-search-aggs |
cbuescher
commented
Jun 8, 2018
| module project(':modules:lang-mustache') | ||
| } | ||
|
|
||
| run { |
There was a problem hiding this comment.
The IT test where running without addind this run section, however I saw in the commit where you moved the reindex tests that you added them. I'm curious if/when this section is used. Is it for the case when I start clusters from the command line from one of the plugin/module directories or is it used by something else? Or can I safely remove it in my case?
There was a problem hiding this comment.
It is used for ./gradlew -p modules/rank-eval run. I try to keep the integTestCluster and run configurations the same.
|
Wrong Nik. Poor dude gets my pings every once in a while. |
nik9000
approved these changes
Jun 15, 2018
| module project(':modules:lang-mustache') | ||
| } | ||
|
|
||
| run { |
There was a problem hiding this comment.
It is used for ./gradlew -p modules/rank-eval run. I try to keep the integTestCluster and run configurations the same.
cbuescher
pushed a commit
that referenced
this pull request
Jun 15, 2018
This change moves tests in `smoke-test-rank-eval-with-mustache` into the main ranking evaluation module by declaring that the integration testing cluster requires the `lang-mustache` plugin. This avoids having to maintain the qa project for only one basic test suite.
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2018
* master: Upgrade to Lucene-7.4.0-snapshot-518d303506 (#31360) Rankeval: Fold template test project into main module (#31203) Add QA project and fixture based test for discovery-ec2 plugin (#31107) [Docs] Remove reference to repository-s3 plugin creating an S3 bucket (#31359) REST Client: NodeSelector for node attributes (#31296) LLClient: Fix assertion on windows Add details section for dcg ranking metric (#31177) [ML] Re-enable tests muted in #30982
dnhatn
added a commit
that referenced
this pull request
Jun 15, 2018
* 6.x: Upgrade to Lucene-7.4.0-snapshot-518d303506 (#31360) [ML] Implement new rules design (#31110) (#31294) Remove RestGetAllAliasesAction (#31308) CCS: don't proxy requests for already connected node (#31273) Rankeval: Fold template test project into main module (#31203) [Docs] Remove reference to repository-s3 plugin creating an S3 bucket (#31359) More detailed tracing when writing metadata (#31319) Add details section for dcg ranking metric (#31177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves tests in
smoke-test-rank-eval-with-mustacheinto the mainranking evaluation module by declaring that the integration testing cluster
requires the
lang-mustacheplugin. This avoids having to maintain the qaproject for only one basic test suite.