Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rankeval: Fold template test project into main module #31203

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Rankeval: Fold template test project into main module #31203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions modules/rank-eval/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,12 @@ esplugin {
hasClientJar = true
}

integTestCluster {
// Modules who's integration is explicitly tested in integration tests
module project(':modules:lang-mustache')
}

run {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IT test where running without addind this run section, however I saw in the commit where you moved the reindex tests that you added them. I'm curious if/when this section is used. Is it for the case when I start clusters from the command line from one of the plugin/module directories or is it used by something else? Or can I safely remove it in my case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for ./gradlew -p modules/rank-eval run. I try to keep the integTestCluster and run configurations the same.

// Modules who's integration is explicitly tested in integration tests
module project(':modules:lang-mustache')
}
0 ...test/rank-eval/10_rank_eval_templated.yml → ...test/rank_eval/40_rank_eval_templated.yml
View file
Open in desktop
File renamed without changes.
27 changes: 0 additions & 27 deletions qa/smoke-test-rank-eval-with-mustache/build.gradle
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions ...t/java/org/elasticsearch/index/rankeval/SmokeTestRankEvalWithMustacheYAMLTestSuiteIT.java
View file
Open in desktop

This file was deleted.