Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale test logging annotations #43403

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

jasontedor
Copy link
Member

This commit removes some very old test logging annotations that appeared to be added to investigate test failures that are long since closed. If these are needed, they can be added back on a case-by-case basis with a comment associating them to a test failure.

This commit removes some very old test logging annotations that appeared
to be added to investigate test failures that are long since closed. If
these are needed, they can be added back on a case-by-case basis with a
comment associating them to a test failure.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jasontedor jasontedor requested a review from rjernst June 20, 2019 00:40
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jasontedor jasontedor merged commit 0a16e41 into elastic:master Jun 20, 2019
jasontedor added a commit that referenced this pull request Jun 20, 2019
This commit removes some very old test logging annotations that appeared
to be added to investigate test failures that are long since closed. If
these are needed, they can be added back on a case-by-case basis with a
comment associating them to a test failure.
jasontedor added a commit that referenced this pull request Jun 20, 2019
This commit removes some very old test logging annotations that appeared
to be added to investigate test failures that are long since closed. If
these are needed, they can be added back on a case-by-case basis with a
comment associating them to a test failure.
@jasontedor jasontedor deleted the stale-test-logging branch June 20, 2019 03:23
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 20, 2019
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates elastic#43403
DaveCTurner added a commit that referenced this pull request Jun 21, 2019
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates #43403
DaveCTurner added a commit that referenced this pull request Jun 21, 2019
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates #43403
@jasontedor jasontedor restored the stale-test-logging branch July 17, 2019 07:41
@jasontedor jasontedor deleted the stale-test-logging branch July 17, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants