Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce TestLogging usage in DisruptionIT tests #43411

Merged
merged 4 commits into from
Jun 21, 2019
Merged

Reduce TestLogging usage in DisruptionIT tests #43411

merged 4 commits into from
Jun 21, 2019

Conversation

DaveCTurner
Copy link
Contributor

Removes @TestLogging annotations in *DisruptionIT tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates #43403

@DaveCTurner
Reduce TestLogging usage in DisruptionIT tests
cb10111 
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates elastic#43403
@DaveCTurner DaveCTurner added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >test Issues or PRs that are addressing/adding tests labels Jun 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@DaveCTurner
Copy link
Contributor Author

Armin I asked you to review because I removed the logging annotation on SnapshotDisruptionIT on which you've been working recently. Just wanted to check you're not chasing anything needing extra logging there.

jasontedor
jasontedor approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, what about the new DiskDisruptionIT that was added today. Can that be removed, now, or soon in the future?

original-brownbear
original-brownbear approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, I already have all the intel I need for the open snapshot disruption IT issue (it's resolved by the snapshot cleanup logic PR). Thanks for pinging though :)

@DaveCTurner DaveCTurner merged commit 1df6748 into elastic:master Jun 21, 2019
@DaveCTurner DaveCTurner deleted the 2019-06-20-reduce-testlogging-in-disruption-tests branch June 21, 2019 05:59
DaveCTurner added a commit that referenced this pull request Jun 21, 2019
@DaveCTurner
Reduce TestLogging usage in DisruptionIT tests (#43411)
e4fd0ce 
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only
tests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.

Relates #43403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

@original-brownbear original-brownbear original-brownbear approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees
No one assigned
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >test Issues or PRs that are addressing/adding tests v7.3.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @jasontedor @original-brownbear @jakelandis