Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Color rules are not applied for null series #100250

Closed
stratoula opened this issue May 18, 2021 · 2 comments · Fixed by #100404
Closed

[TSVB] Color rules are not applied for null series #100250

stratoula opened this issue May 18, 2021 · 2 comments · Fixed by #100404
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Kibana version:
7.12+

Describe the bug:
By stop inserting zeroes for null series (#90861), we introduced a bug. Specifically, all the color rules that try to add a color rule for less than 0 are not applied.

Steps to reproduce:

  1. Create a TSVB metric viz
  2. Use the kibana_sample_data_logs dataset without any change
  3. I used a timerange of the last 12 minutes in order to have null series
  4. Apply a color rule (change the background color for metric less than or equal to 0
  5. The color is not applied

Expected behavior:
Users expect the color rule to work

Screenshots (if relevant):
image

@stratoula stratoula added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp
Copy link
Contributor

I have one suggestion to implement it in a little bit different way. This solution should be more flexible
Let's:

  1. add new rule e.g. empty
    image
  2. create a migration script to fix all broken TSVB visualizations by adding a new empty rule. I think it should work for both less/greater than or equal : 0

kibanamachine added a commit to Kuznietsov/kibana that referenced this issue May 24, 2021
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue May 25, 2021
Kuznietsov added a commit to Kuznietsov/kibana that referenced this issue May 28, 2021
# Conflicts:
#	src/plugins/visualizations/server/migrations/visualization_saved_object_migrations.test.ts
#	src/plugins/visualizations/server/migrations/visualization_saved_object_migrations.ts
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue May 31, 2021
Kuznietsov added a commit to Kuznietsov/kibana that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants