-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Stop inserting zeroes for null series #90861
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@wylieconlon thanx for this, it works fine! My only concern is that it also affects and on the metric tab, the chart appears with no value which may be confusing. I mean count 0 makes sense to me. I would love your thoughts on that. |
@stratoula @wylieconlon I agree with both of you. We should definitely remove that wrong Small suggestion, I think from a UI point of view, in such cases it's better to se For |
@stratoula @alexwizp thanks, I agree that this would make more sense. Will update. |
@stratoula @alexwizp I fixed the default values and handling of 0 vs null. |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, works as expected, thank you @wylieconlon!
LGTM! Tested locally, thank you for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test update looks good to me
* [TSVB] Stop inserting zeroes for null series * Replace empty default value with hyphen * Stop treating 0 as false * Fix test cases Co-authored-by: Kibana Machine <[email protected]>
* [TSVB] Stop inserting zeroes for null series * Replace empty default value with hyphen * Stop treating 0 as false * Fix test cases Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* [TSVB] Stop inserting zeroes for null series * Replace empty default value with hyphen * Stop treating 0 as false * Fix test cases Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
TSVB finds the series names first, and then applies the date histogram after. This leads to cases where a series will be displayed even though there is no data at all for the time bucket that it's showing.
I have created an extreme example where the last value of the series is totally missing, and it will show an empty value instead of zero. In most cases this won't happen, most users will see numbers:
Fixes #90220
Checklist