-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface deprecation logs from Kibana CI #120043
Labels
Team:Operations
Team label for Operations Team
Comments
rudolf
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Nov 30, 2021
Pinging @elastic/kibana-core (Team:Core) |
This was referenced Nov 30, 2021
This was referenced Dec 7, 2021
Closed
rudolf
removed
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To help teams audit, fix and suppress deprecation warnings originating from Elastic products we need to instrument Kibana CI.
Short term:
Medium term: @elastic/kibana-operations
Create a workflow/process to manage deprecation logs in Kibana
ignored_deprecations
file which uses the deprecation message and test name as unique keys.ignored_deprecations
file and create an issue for the respective team to address.We should distinguish between log originating from user supplied queries (e.g. console), kibana or originating from test suites themselves.
There are several ways we could surface deprecation logs:
1. Deprecation logger to stdout
By setting the following
log4j2.properties
we can direct deprecation logs in JSON format to stdout. TheToolingLog
could then write these to file so that they appear in the final CI logs.Example log line:
2.
warning
response headerEach API request that triggers a deprecation will include a warning header in it's response for example:
Similar to how
elasticsearch.query
logger context (previouslyelasticsearch.logQueries
config option) works, we can log a lot of extra context like the entire query and the stack trace:3. Query the
.ds-.logs-deprecation.elasticsearch-default
We explored this approach in #117937 but this provides the least context since we can only collect the deprecation logs at a set interval or time, e.g. at the end of a test suite, making it hard to trace back to the offending test and even harder to the corresponding line of source code.
The text was updated successfully, but these errors were encountered: