Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface deprecation logs from CI #117937

Closed
wants to merge 13 commits into from
Closed

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Nov 8, 2021

Summary

Experiment to see how many tests create deprecation logs. Not intended to be merged as is.

How to use this:

  1. comment with @elasticmachine merge upstream to merge in the latest 7.16 changes and kick off a build
  2. Wait for the build to complete and note the build number
  3. Use https:/elastic/kibana-buildkite/tree/main/tools#all-logs to download all logs of a build
  4. grep for all deprecation logs in the output directory of the above command:
    grep -rho 'ES DEPRECATION .*' out/logs/kibana-pull-request/7004 | sort -ui 

Current deprecation logs 1 Dec

ES DEPRECATION CRITICAL At least one multi-field, [english], was encountered that itself contains a multi-field. Defining multi-fields within a multi-field is deprecated and will no longer be supported in 8.0. To resolve the issue, all instances of [fields] that occur within a [fields] block should be removed from the mappings, either by flattening the chained [fields] blocks into a single level, or switching to [copy_to] if appropriate.
ES DEPRECATION CRITICAL Parameter [strategy] is deprecated and will be removed in a future version
ES DEPRECATION CRITICAL Parameter [tree] is deprecated and will be removed in a future version
ES DEPRECATION CRITICAL Translog retention settings [index.translog.retention.age] and [index.translog.retention.size] are deprecated and effectively ignored. They will be removed in a future version.
ES DEPRECATION CRITICAL [types removal] Specifying types in bulk requests is deprecated.
ES DEPRECATION CRITICAL [types removal] Specifying types in document get requests is deprecated, use the /{index}/_doc/{id} endpoint instead.
ES DEPRECATION CRITICAL [types removal] Specifying types in document update requests is deprecated, use the endpoint /{index}/_update/{id} instead.
ES DEPRECATION CRITICAL [types removal] Types are deprecated in [ids] queries.
ES DEPRECATION CRITICAL [types removal] Using include_type_name in create index requests is deprecated. The parameter will be removed in the next major version.
ES DEPRECATION CRITICAL the default value for the ?wait_for_active_shards parameter will change from '0' to 'index-setting' in version 8; specify '?wait_for_active_shards=index-setting' to adopt the future default behaviour, or '?wait_for_active_shards=0' to preserve today's behaviour
ES DEPRECATION WARN Legacy index templates are deprecated in favor of composable templates.
ES DEPRECATION WARN [xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
ES DEPRECATION WARN [xpack.monitoring.collection.interval] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
ES DEPRECATION WARN index name [.alerts-observability.apm.alerts] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.fleet-agent-7] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.internal.alerts-observability.apm.alerts-default-000001] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.kibana-alerting-test-data] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.kibana-event-log-7.9.0-000001] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.migration-a] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.monitoring-beats-6-2018.08.31] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.monitoring-es-6-2017.08.15] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN index name [.siem-signals-default-000001] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices
ES DEPRECATION WARN this request accesses aliases with names reserved for system indices: [.kibana_7.16.0, .kibana_task_manager, .kibana_task_manager_7.16.0, .security, .data-frame-internal-3, .kibana], but in a future major version, direct access to system indices and their aliases will not be allowed
ES DEPRECATION WARN this request accesses aliases with names reserved for system indices: [.kibana_7.16.0, .kibana_task_manager, .kibana_task_manager_7.16.0, .security, .kibana], but in a future major version, direct access to system indices and their aliases will not be allowed
ES DEPRECATION WARN this request accesses aliases with names reserved for system indices: [.kibana_task_manager_7.16.0, .fleet-enrollment-api-keys, .kibana, .fleet-policies, .kibana_7.16.0, .kibana_task_manager, .security], but in a future major version, direct access to system indices and their aliases will not be allowed
ES DEPRECATION WARN this request accesses aliases with names reserved for system indices: [.kibana_task_manager_7.16.0, .kibana, .kibana_7.16.0, .kibana_task_manager, .security], but in a future major version, direct access to system indices and their aliases will not be allowed
ES DEPRECATION WARN this request accesses aliases with names reserved for system indices: [.ml-config], but in a future major version, direct access to system indices and their aliases will not be allowed
ES DEPRECATION WARN this request accesses system indices: [.async-search, .tasks], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.async-search], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.fleet-servers-7], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_1], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_7.13.5_001], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_7.16.0_001], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_security_session_1], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_task_manager_7.16.0_001], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.kibana_task_manager_test_result], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.security-7, .tasks], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.security-7, .transform-internal-007], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.security-7], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.security-tokens-7], but in a future major version, direct access to system indices will be prevented by default
ES DEPRECATION WARN this request accesses system indices: [.tasks], but in a future major version, direct access to system indices will be prevented by default

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 8, 2021
@rudolf
Copy link
Contributor Author

rudolf commented Nov 16, 2021

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 16, 2021
@rudolf
Copy link
Contributor Author

rudolf commented Nov 18, 2021

@elasticmachine merge upstream

@rudolf rudolf changed the title kbn-test log when test creates deprecation logs Surface deprecation logs from CI Nov 25, 2021
@rudolf
Copy link
Contributor Author

rudolf commented Nov 25, 2021

@elasticmachine merge upstream

@rudolf rudolf marked this pull request as ready for review November 26, 2021 06:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@@ -308,7 +336,9 @@ export function createTestEsCluster<
* in this list.
*/
getHostUrls(): string[] {
return this.ports.map((p) => format({ ...esTestConfig.getUrlParts(), port: p }));
return this.ports.map((p) =>
format({ ...esTestConfig.getUrlParts(ssl), port: p, protocol: ssl ? 'https' : 'http' })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-operations I have to override protocol here because TEST_ES_URL doesn't have the correct protocol. So although this works it feels a bit hacky.

@juliaElastic
Copy link
Contributor

@elasticmachine merge upstream

@rudolf rudolf marked this pull request as draft December 7, 2021 14:08
@mistic mistic added the v7.17.0 label Dec 16, 2021
@rudolf
Copy link
Contributor Author

rudolf commented Jan 13, 2022

@elasticmachine merge upstream

@rudolf rudolf changed the base branch from 7.16 to 7.17 January 13, 2022 20:23
@rudolf rudolf changed the base branch from 7.17 to 7.16 January 13, 2022 20:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v7.16.1 v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants