Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Move integration and e2e tests over to use datastreams #136627

Closed
Mpdreamz opened this issue Jul 19, 2022 · 1 comment
Closed

[APM] Move integration and e2e tests over to use datastreams #136627

Mpdreamz opened this issue Jul 19, 2022 · 1 comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm Team:APM All issues that need APM UI Team support test v8.5.0

Comments

@Mpdreamz
Copy link
Member

Mpdreamz commented Jul 19, 2022 •
edited by sorenlouv
Loading

Today the integration tests and e2e tests still rely on indexing to legacyIndices (forceLegacyIndices) see:

kibana/x-pack/plugins/apm/ftr_e2e/cypress/plugins/index.ts

Line 45 in 708d6d0

forceLegacyIndices: true,

kibana/x-pack/test/apm_api_integration/common/synthtrace_es_client_service.ts

Line 15 in 708d6d0

forceLegacyIndices: true,

To better reflect the new defaults from apm-server we should switch these to false and update our tests accordingly.

cc @elastic/apm-ui
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 19, 2022
@Mpdreamz Mpdreamz added the Team:APM All issues that need APM UI Team support label Jul 19, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 19, 2022
@sorenlouv sorenlouv self-assigned this Aug 2, 2022
@sorenlouv sorenlouv mentioned this issue Aug 3, 2022
Closed
@dannycroft dannycroft mentioned this issue Aug 10, 2022
Closed
@sorenlouv
Copy link
Member

sorenlouv commented Aug 24, 2022 •
edited
Loading

Resolved by:

@MiriamAparicio MiriamAparicio added the apm:test-plan-done Pull request that was successfully tested during the test plan label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm Team:APM All issues that need APM UI Team support test v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Stabilize cypress tests and move to datastreams sorenlouv/kibana
4 participants
@dannycroft @sorenlouv @Mpdreamz @MiriamAparicio