Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Make usage of _source compatible with synthetic source #84507

Closed
dgieselaar opened this issue Nov 30, 2020 · 2 comments · Fixed by #139643
Closed

[APM] Make usage of _source compatible with synthetic source #84507

dgieselaar opened this issue Nov 30, 2020 · 2 comments · Fixed by #139643
Labels
apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.5.0

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Nov 30, 2020 •
edited by dannycroft
Loading

We're currently using _source to get document fields. With synthetic source, which will allow significant storage savings for users, we can no longer depend on the source document format APM Server is using. We should make our usage of _source compatible with synthetic source, either by adopting a similar hydrating mechanism as synthetic source or by leveraging the Fields API.

We currently cannot do this for transaction, span and error documents, as some fields require us to access the raw _source, but we should be able to implement this for metric documents. We should also attempt to limit our usage of _source for the other document types as much as possible.

Links
@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Nov 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added [zube]: Inbox v7.12.0 technical debt Improvement of the software architecture and operational architecture and removed v7.12.0 [zube]: Inbox labels Dec 1, 2020
@dgieselaar
Copy link
Member Author

dgieselaar commented Dec 7, 2020 •
edited
Loading

We should also look into replacing our usage of top_hits with top_metrics where possible.

@sorenlouv sorenlouv mentioned this issue Mar 24, 2021
Closed
@axw axw mentioned this issue Aug 24, 2021
Open
@dannycroft dannycroft added apm:release-feature APM UI - Release Feature Goal v8.5.0 and removed [zube]: Backlog technical debt Improvement of the software architecture and operational architecture labels Aug 10, 2022
@dgieselaar dgieselaar changed the title [APM] Look into using Fields API instead of relying on _source [APM] Use Fields API where possible instead of _source Aug 10, 2022
@dgieselaar dgieselaar changed the title [APM] Use Fields API where possible instead of _source [APM] Make usage of _source compatible with synthetic source Aug 10, 2022
@MiriamAparicio MiriamAparicio self-assigned this Aug 24, 2022
@dgieselaar dgieselaar linked a pull request Aug 30, 2022 that will close this issue
[APM] Mock synthetic source for metric documents #139643
Merged
@dannycroft dannycroft added apm:test-plan-done Pull request that was successfully tested during the test plan apm:test-plan-8.5.0 and removed apm:test-plan-8.5.0 labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Mock synthetic source for metric documents dgieselaar/kibana
5 participants
@dannycroft @sorenlouv @dgieselaar @elasticmachine @MiriamAparicio