Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-aggregated histogram type #52426

Closed
2 of 3 tasks
wylieconlon opened this issue Dec 6, 2019 · 11 comments
Closed
2 of 3 tasks

Support pre-aggregated histogram type #52426

wylieconlon opened this issue Dec 6, 2019 · 11 comments
Assignees
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Dec 6, 2019

ES now supports the pre-aggregated histogram type. elastic/elasticsearch#48580

According to those docs, this type is intended to be used with:

  • percentiles aggregation
  • percentile ranks aggregation
  • exists query

Which we support in the default editor.

Support in:

@wylieconlon wylieconlon added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the Feature:Data Views Data Views code and UI - index patterns before 8.0 label Dec 9, 2019
@timroes
Copy link
Contributor

timroes commented Dec 9, 2019

Just for my clarification: As far as I can see, this datatype won't require additional code for aggregations (the aggregation syntax still looks the same), it's just a new field type that needs to be supported? I added the Index pattern label for that, to highlight we first need support for that field type in there.

@exekias
Copy link
Contributor

exekias commented Dec 19, 2019

thanks for opening this!. We (observability) plan to use this type in metrics and APM. cc @sorantis @andresrc

Does this issue cover making it also available in TSVB?

@graphaelli
Copy link
Member

graphaelli commented Jan 16, 2020

Similar to @exekias, I'm wondering what this issue covers? I'm looking for a built in visualization type to show histograms over time, like:

image

@wylieconlon
Copy link
Contributor Author

Per the original issue: This field can be used in standard percentile and percentile_ranks aggregations. Those aggregations are already supported by many of our visualizations. This issue is focused on changing our mapping of datatype to supported aggregations (using agg configs). So there needs to be a map of something like:

{
  "histogram": ["percentiles", "percentile_ranks"]
}

@sorantis
Copy link

@simianhacker do we need to do any changes (except the above) to TSVB to add this type?

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@simianhacker
Copy link
Member

@sorantis I think that's something the visualization team will take care of for TSVB.

@timroes timroes changed the title [Agg configs] Support pre-aggregated histogram type Support pre-aggregated histogram type Jan 30, 2020
@sorantis sorantis added the Feature:TSVB TSVB (Time Series Visual Builder) label Feb 3, 2020
@ThomThomson ThomThomson self-assigned this Mar 4, 2020
@jsoriano
Copy link
Member

I am starting to try to use histograms in dashboards, in elastic/beats#17736, and they work nice with visualize, thanks! I look forward to see this feature on TSVB as well.

Something I am missing is the possibility of selecting a format in the index pattern. For example I would like to display some values as durations. Is this possible at the moment?

@timroes
Copy link
Contributor

timroes commented Apr 20, 2020

@jsoriano That's not possible, and we currently don't have any plans to support field formatters generically for histogram field types, given the way field formatters work this would become a bit tricky, since the aggregated format is so different from the "raw value" format (as it's stored in the document), which field formatters currently don't make a difference for.

We'd rather wait for support for this in Lens, which has field formatter options on a per visualization level and thus doesn't suffer from that problem.

@simianhacker simianhacker self-assigned this Jun 23, 2020
@sgrodzicki sgrodzicki removed this from the Metrics UI 7.9 milestone Jul 14, 2020
@wylieconlon
Copy link
Contributor Author

Closing as we now support histograms in several places. Support for histograms in Lens is tracked here: #74581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests