Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exists filtering on non-searchable types #60572

Closed
ThomThomson opened this issue Mar 18, 2020 · 5 comments
Closed

Exists filtering on non-searchable types #60572

ThomThomson opened this issue Mar 18, 2020 · 5 comments
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement

Comments

@ThomThomson
Copy link
Contributor

Overview

the issue #52426 for adding the pre-aggregated histogram type to Kibana states that the histogram data type should be filterable using only the operators 'exists' and 'does not exist'.

The problem with this is that all fields that appear in the filter dropdown must be of a type that is searchable based on the field capabilities api. An approach to get around this would involve changing the isFilterable method (which determines which fields show up in the dropdown) to include any types marked as filterable. This change may result in undesirable behavior unless all the edge cases are understood. This issue is a place to discuss this change.

@ThomThomson
Copy link
Contributor Author

@polyfractal, do you know of any cases where a non-searchable field would not work with an exists filter?

@thomasneirynck thomasneirynck added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@polyfractal
Copy link
Contributor

So... it's not guaranteed, but in most cases a field will support exists queries even if they are not "searchable" (because they use the doc values to check).

There are some exceptions, e.g. the Rank Feature field does not support exists, but I did a quick skim and most other fields do, even those that are traditional not searchable (binary fields, histogram, _seq_no, etc)

I'm not sure how helpful that is since it's not universal, but it's probably safe to assume most types support exists for the general case.

@timroes timroes added Feature:Filters and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 19, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement
Projects
None yet
Development

No branches or pull requests

6 participants