[SOM] Add visibleInManagement option to management metadata
#112073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:Saved Objects Management
release_note:skip
pgayvallet
commented
Sep 15, 2021
Comment on lines
19
to
21
| .getImportableAndExportableTypes() | ||
| .filter((type) => type.management!.visibleInManagement ?? true) | ||
| .map((type) => type.name); |
There was a problem hiding this comment.
Note: I could have added the same filtering in other SOM routes (e.g find, scroll_count), but I think it's not worth it because:
- The list of type from the
_allowed_typesendpoint is the source of truth for the UI regarding the types the user can search for or list in the SOM - Even if the user was to manually call the SOM endpoint while specifying types that are exportable but not visible in management, it's not a vulnerability or a privilege escalation, as it would have been allowed to do the same using the public SO apis)
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Sep 20, 2021
|
|
||
| describe('types with `visibleInManagement` ', () => { | ||
| before(async () => { | ||
| await esArchiver.load( |
…sibleInManagement
💚 Build SucceededMetrics [docs]History
To update your PR or re-run it, just comment with: |
pgayvallet
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 21, 2021
…c#112073) * implement SavedObjectsTypeManagementDefinition.visibleInManagement * update generated doc * improve FTR tests * fix FTR test
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 21, 2021
… (#112639) * implement SavedObjectsTypeManagementDefinition.visibleInManagement * update generated doc * improve FTR tests * fix FTR test Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #110146
Introduce a new
visibleInManagementconfiguration option inSavedObjectType.managementto allow type owners to define a type as exportable while hiding it from the SOM user interface.Refer to #110146 for more functional details.
Checklist