-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOM] Add visibleInManagement
option to management metadata
#112073
Merged
pgayvallet
merged 7 commits into
elastic:master
from
pgayvallet:kbn-110146-SOM-visibleInManagement
Sep 21, 2021
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5917fe8
implement SavedObjectsTypeManagementDefinition.visibleInManagement
pgayvallet 33f042f
update generated doc
pgayvallet 9b1b3e7
improve FTR tests
pgayvallet f95268f
Merge remote-tracking branch 'upstream/master' into kbn-110146-SOM-vi…
pgayvallet 996e843
fix FTR test
pgayvallet bbeeb2b
Merge remote-tracking branch 'upstream/master' into kbn-110146-SOM-vi…
pgayvallet bd66932
Merge remote-tracking branch 'upstream/master' into kbn-110146-SOM-vi…
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...-plugin-core-server.savedobjectstypemanagementdefinition.visibleinmanagement.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-core-server](./kibana-plugin-core-server.md) > [SavedObjectsTypeManagementDefinition](./kibana-plugin-core-server.savedobjectstypemanagementdefinition.md) > [visibleInManagement](./kibana-plugin-core-server.savedobjectstypemanagementdefinition.visibleinmanagement.md) | ||
|
||
## SavedObjectsTypeManagementDefinition.visibleInManagement property | ||
|
||
When set to false, the type will not be listed or searchable in the SO management section. Main usage of setting this property to false for a type is when objects from the type should be included in the export via references or export hooks, but should not directly appear in the SOM. Defaults to `true`<!-- -->. | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
visibleInManagement?: boolean; | ||
``` | ||
|
||
## Remarks | ||
|
||
`importableAndExportable` must be `true` to specify this property. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
.../functional/fixtures/es_archiver/saved_objects_management/visible_in_management/data.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"type": "doc", | ||
"value": { | ||
"id": "test-not-visible-in-management:vim-1", | ||
"index": ".kibana", | ||
"source": { | ||
"coreMigrationVersion": "7.14.0", | ||
"references": [ | ||
], | ||
"test-not-visible-in-management": { | ||
"enabled": true, | ||
"title": "vim-1" | ||
}, | ||
"type": "test-not-visible-in-management", | ||
"updated_at": "2018-12-21T00:43:07.096Z" | ||
}, | ||
"type": "_doc" | ||
} | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I could have added the same filtering in other SOM routes (e.g
find
,scroll_count
), but I think it's not worth it because:_allowed_types
endpoint is the source of truth for the UI regarding the types the user can search for or list in the SOM