Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation logs created by Elastic products #121174

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Dec 14, 2021

This if the feature branch to remove the deprecations logs generated by Elastic products.

The deprecation logs coming from Elasticsearch have a new elasticsearch.elastic_product_origin field which allows us to hide from the users deprecations that are generated by our own products as there is nothing that the user can act on during the upgrade process.

Upgrade assistant

  • We will filter out the deprecation when counting the logs

Screenshot 2021-11-05 at 11 14 22

  • When navigating to Discover or Observability apps we will apply a filter to not display deprecation logs coming from Elastic products.

Note to reviewers

The work of this feature branch has been reviewed in separates PRs. The main one being #121389 (steps on how to test this PR are in the description)

Fixes #120152

@sebelga
Copy link
Contributor Author

sebelga commented Dec 20, 2021

@elasticmachine merge upstream

@sebelga sebelga changed the base branch from 7.16 to 7.17 December 20, 2021 12:23
@sebelga sebelga changed the base branch from 7.17 to 7.16 December 20, 2021 12:23
@sebelga sebelga changed the base branch from 7.16 to 7.17 December 20, 2021 16:49
@sebelga sebelga marked this pull request as ready for review December 21, 2021 17:33
@sebelga sebelga added Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.17.0 v8.0.0 v8.1.0 labels Dec 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sebelga
Copy link
Contributor Author

sebelga commented Dec 22, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 140 204 +64

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 128.1KB 168.5KB +40.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 18.3KB 18.5KB +250.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm. 🐑 it!

@sebelga
Copy link
Contributor Author

sebelga commented Dec 22, 2021

Thanks for the review @sabarasaba !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants