Visualization specific timeranges #15998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
Feature:Dashboard
nreese
reviewed
Jan 12, 2018
Good point, I'll add some unit tests for the |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jan 17, 2018
* No longer converting the $scope.timeRange to absolute values in visualize.js * Now using searchSource.filter as opposed to manual approach * Adding extensible filters and only including the first timeRange filter * Removing the forceNow stuff, we'll deal with this in another PR * Adding omment about removing null/undefined filters * Adding vis.getTimeRange and using it in the Date Histogram * Removing the test hard-coded timeRange * Adding tests for default filter "filters" * Adding custom filter prediate test
kobelb
added
the
non-issue
kobelb
added a commit
that referenced
this pull request
Jan 17, 2018
* No longer converting the $scope.timeRange to absolute values in visualize.js * Now using searchSource.filter as opposed to manual approach * Adding extensible filters and only including the first timeRange filter * Removing the forceNow stuff, we'll deal with this in another PR * Adding omment about removing null/undefined filters * Adding vis.getTimeRange and using it in the Date Histogram * Removing the test hard-coded timeRange * Adding tests for default filter "filters" * Adding custom filter prediate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach to visualization specific timeranges had a few deficiencies:
This PR changes the approach, and we're no longer breaking the SearchSource inheritance. Instead, I've made the "filter filtering" a first class citizen of the SearchSource and added an extension point so that specific SearchSource instances are able to reject certain filters. This allows us to ensure that only one range filter is added to the SearchSource, and ignore the global time filter that was being added.
Additionally, we're no longer calculating the absolute min/max times from the timeRange when first "linking" the Visualization so that these values are able to change over time. The way that we're passing the custom timeRange to the DateHistogramAggregation has been revised as well to alleviate the same limitation of the values changing over time.