Rename min/max properties into from/to in loader #16638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Docs
Feature:Visualizations
thomasneirynck
approved these changes
Feb 9, 2018
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 9, 2018
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 9, 2018
timroes
added a commit
that referenced
this pull request
Feb 9, 2018
timroes
added a commit
that referenced
this pull request
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15998 changed the behavior of the visualization loader. It now expects the
timeRangeobject to have thefromandtokey instead ofminandmaxkey as earlier.We decided to leave the property names like this, since they align better with the time picker and other usage around Kibana. So this PR will just fix the documentation for 6.2, 6.x and master to reflect that change.