Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reporting pdf v1 export type #178292

Closed
wants to merge 9 commits into from

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Mar 8, 2024

Summary

Depends on #178281
Closes #175735

  1. Removes printable_pdf from the Reporting Export Type Registry, as it has been replaced with printable_pdf_v2 in [Reporting] Create reports with full state required to generate the report #101048
  2. Additional clean up of png artifacts that was missed in [Reporting] Remove PNG V1 #162517

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@vadimkibana
Copy link
Contributor Author

/ci

@tsullivan
Copy link
Member

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 22, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / CsvGenerator Scroll strategy uses the scroll context to page all the data
  • [job] [logs] Jest Tests #4 / CsvGenerator Scroll strategy uses the scroll context to page all the data
  • [job] [logs] Jest Tests #10 / Handle request to generate Enqueue Job creates a report object to queue
  • [job] [logs] Jest Tests #10 / Handle request to generate Enqueue Job creates a report object to queue
  • [job] [logs] FTR Configs #31 / Reporting APIs Network Policy should fail job when page violates the network policy
  • [job] [logs] FTR Configs #31 / Reporting APIs Network Policy should fail job when page violates the network policy
  • [job] [logs] FTR Configs #69 / reporting management app Listing of Reports Paginates historical reports
  • [job] [logs] FTR Configs #69 / reporting management app Listing of Reports Paginates historical reports
  • [job] [logs] Jest Tests #10 / Reporting Plugin config and export types registration expect all report types to be in registry
  • [job] [logs] Jest Tests #10 / Reporting Plugin config and export types registration expect all report types to be in registry
  • [job] [logs] Jest Tests #10 / ReportListing flyout shows the enabled "Download" button in the actions menu for a job is done
  • [job] [logs] Jest Tests #10 / ReportListing flyout shows the enabled "Download" button in the actions menu for a job is done

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/reporting-export-types-csv-common 22 25 +3
@kbn/reporting-export-types-pdf 33 16 -17
@kbn/reporting-export-types-pdf-common 11 8 -3
@kbn/reporting-export-types-png-common 11 9 -2
total -19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 72.1KB 72.1KB -90.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 43.2KB 42.6KB -644.0B
Unknown metric groups

API count

id before after diff
@kbn/reporting-export-types-csv-common 25 27 +2
@kbn/reporting-export-types-pdf 34 17 -17
@kbn/reporting-export-types-pdf-common 14 11 -3
@kbn/reporting-export-types-png-common 13 11 -2
total -20

References to deprecated APIs

id before after diff
@kbn/reporting-export-types-pdf 3 0 -3
reporting 21 17 -4
total -7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PrintablePdfV1
4 participants