Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reporting pdf v1 export type #178292

Closed
wants to merge 9 commits into from
Closed

remove reporting pdf v1 export type #178292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c4cd23
remove reporting pdf v1 export type
vadimkibana Mar 8, 2024
33b8b7c
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 8, 2024
f28f359
Merge branch 'main' into rm-printable_pdf
tsullivan Mar 22, 2024
dd7a18f
remove no-longer-used deprecations
tsullivan Mar 22, 2024
d3ba4ff
clean up more deprecated code and types
tsullivan Mar 22, 2024
3c28462
Merge branch 'main' into rm-printable_pdf
tsullivan Mar 22, 2024
701bfc0
fix jest tests
tsullivan Mar 22, 2024
b73e2fc
more deprecated code removal
tsullivan Mar 22, 2024
dfb8bf5
Remove csv type fixes
tsullivan Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/kbn-reporting/common/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,13 @@ export interface ReportOutput extends TaskRunResult {
*/
export type CsvPagingStrategy = 'pit' | 'scroll';

/**
* @deprecated
*/
export interface BaseParams {
browserTimezone: string; // to format dates in the user's time zone
objectType: string;
objectType: string; // "dashboard", "visualization", "search", "canvas", etc
title: string;
version: string; // to handle any state migrations

// application-specific fields
layout?: LayoutParams; // png & pdf only
pagingStrategy?: CsvPagingStrategy; // csv only
}
Expand All @@ -80,9 +79,6 @@ export type BaseParamsV2 = BaseParams & {
locatorParams: LocatorParams[];
};

/**
* @deprecated
*/
export interface BasePayload extends BaseParams {
headers: string;
spaceId?: string;
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-reporting/export_types/pdf/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@
*/

export { PdfExportType } from './printable_pdf_v2';
export { PdfV1ExportType } from './printable_pdf';
132 changes: 0 additions & 132 deletions packages/kbn-reporting/export_types/pdf/printable_pdf.test.ts
View file
Open in desktop

This file was deleted.

165 changes: 0 additions & 165 deletions packages/kbn-reporting/export_types/pdf/printable_pdf.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/kbn-reporting/export_types/pdf/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"@kbn/reporting-common",
"@kbn/screenshotting-plugin",
"@kbn/reporting-server",
"@kbn/licensing-plugin",
"@kbn/reporting-export-types-pdf-common",
"@kbn/reporting-mocks-server",
]
Expand Down
3 changes: 0 additions & 3 deletions packages/kbn-reporting/export_types/pdf_common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,5 @@
* Side Public License, v 1.
*/

export const PDF_JOB_TYPE = 'printable_pdf';
export const PDF_JOB_TYPE_V2 = 'printable_pdf_v2';

export const PDF_REPORT_TYPE = 'printablePdf';
export const PDF_REPORT_TYPE_V2 = 'printablePdfV2';
14 changes: 0 additions & 14 deletions packages/kbn-reporting/export_types/pdf_common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,3 @@ export interface TaskPayloadPDFV2 extends BasePayload, BaseParamsPDFV2 {
*/
forceNow: string;
}

/**
* @deprecated
*/
interface BaseParamsPDF {
layout: LayoutParams;
relativeUrls: string[];
isDeprecated?: boolean;
}

/**
* @deprecated
*/
export type JobParamsPDFDeprecated = BaseParamsPDF & BaseParams;
3 changes: 0 additions & 3 deletions packages/kbn-reporting/export_types/png_common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,5 @@
* Side Public License, v 1.
*/

export const PNG_REPORT_TYPE = 'PNG';
export const PNG_REPORT_TYPE_V2 = 'pngV2';

export const PNG_JOB_TYPE = 'PNG';
export const PNG_JOB_TYPE_V2 = 'PNGV2';
11 changes: 0 additions & 11 deletions packages/kbn-reporting/export_types/png_common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,6 @@ import { LayoutParams } from '@kbn/screenshotting-plugin/common';

export * from './constants';

interface BaseParamsPNG {
layout: LayoutParams;
forceNow?: string;
relativeUrl: string;
}

export type JobParamsPNGDeprecated = BaseParamsPNG & BaseParams;

// Job payload: structure of stored job data provided by create_job
export type TaskPayloadPNG = BaseParamsPNG & BasePayload;

export interface JobParamsPNGV2 extends BaseParams {
layout: LayoutParams;
/**
Expand Down
Loading