Fix issue w/ running chromium headless over http when Kibana itself is accessed publicly via https #20528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the original reporting request was https
kobelb
approved these changes
Jul 6, 2018
💚 Build Succeeded |
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Jul 9, 2018
Remove the referrer header from report requests.
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Jul 9, 2018
Remove the referrer header from report requests.
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Jul 9, 2018
Remove the referrer header from report requests.
chrisdavies
added a commit
that referenced
this pull request
Jul 9, 2018
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Jul 9, 2018
Remove the referrer header from report requests.
chrisdavies
added a commit
that referenced
this pull request
Jul 9, 2018
stacey-gammon
added
:Sharing
v6.4.0
(Deprecated) Feature:Reporting
|
Just a reminder @chrisdavies to add version tags when merging so we know which version the feature gets into. (already added them to this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run Kibana over https, but the reporting background workers connect to Kibana via an unsecured local connection (e.g. http://0.0.0.0), the report fails due to the fact that it is sending an https referrer header over an unsecured connection. This PR fixes this issue by removing the referrer header altogether.