-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Release Notes for 6.3.2 #21012
Conversation
docs/CHANGELOG.asciidoc
Outdated
|
||
Platform:: | ||
* Defaults to running the {es} functional test server from a snapshot locally | ||
in the {xpack} directory {pull}20585[#20585] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified with @archanid that this PR should be included.
docs/CHANGELOG.asciidoc
Outdated
a dashboard with margins. | ||
|
||
* Fixes issue with running Chromium headless over HTTP when accessing {kib} | ||
publicly via HTTPS {pull}20528[#20528] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR (#20528) is specific to Reporting, so it might be helpful to put it under a "Reporting:" section, unless @chrisdavies prefers otherwise.
docs/CHANGELOG.asciidoc
Outdated
names {pull}20455[#20455] | ||
* [Fixes #20240] Fixes issues with the flickering of visualizations on | ||
refresh {pull}20817[#20817] | ||
* Adds distinct links and float tags to Region Map docs {pull}20361[#20361] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the script is supposed to filter "docs" PRs like #20361 out of the release notes. Not sure how this snuck in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickpeihl said its a significant doc fix and should be included.
docs/CHANGELOG.asciidoc
Outdated
refresh {pull}20817[#20817] | ||
* Adds distinct links and float tags to Region Map docs {pull}20361[#20361] | ||
* Avoids shard failures when performing bbox filter on coordinate | ||
maps {pull}19548[#19548] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasneirynck I think bbox a short form of "geo bounding box" per (https://www.elastic.co/guide/en/elasticsearch/reference/6.3/query-dsl-geo-bounding-box-query.html). If that's true, I think adding the full term might help with searchability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified its "geo bounding box" and will make the fix
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to start including changes related to docs, tests, dev environment, etc. in the release notes, then I think we should separate those things out entirely into a new section at the bottom. Perhaps Important Documentation and Developer changes
or something like that.
While some folks are going to appreciate these items, most of the people reading the release notes don't care about them, and they shouldn't need to wade through them to figure out the changes in the release that actually matter for production deploys. Plus, they're currently listed as bugs, which isn't accurate anyway.
I'm about to go on vacation, so don't block on me giving an LGTM.
I like that suggestion too! |
💚 Build Succeeded |
* [DOCS] Release Notes for 6.3.2 * [DOCS] Clarified bbox in Release Notes * [DOCS] Created section for Important Notes]
This PR is for the Release Notes for 6.3.2