Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Release Notes for 6.3.2 #21012

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Jul 19, 2018

This PR is for the Release Notes for 6.3.2


Platform::
* Defaults to running the {es} functional test server from a snapshot locally
in the {xpack} directory {pull}20585[#20585]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you've heard otherwise from @archanid I suspect the PR #20585 should be omitted from this list. Test-related PRs usually are, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified with @archanid that this PR should be included.

a dashboard with margins.

* Fixes issue with running Chromium headless over HTTP when accessing {kib}
publicly via HTTPS {pull}20528[#20528]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR (#20528) is specific to Reporting, so it might be helpful to put it under a "Reporting:" section, unless @chrisdavies prefers otherwise.

names {pull}20455[#20455]
* [Fixes #20240] Fixes issues with the flickering of visualizations on
refresh {pull}20817[#20817]
* Adds distinct links and float tags to Region Map docs {pull}20361[#20361]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the script is supposed to filter "docs" PRs like #20361 out of the release notes. Not sure how this snuck in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickpeihl said its a significant doc fix and should be included.

refresh {pull}20817[#20817]
* Adds distinct links and float tags to Region Map docs {pull}20361[#20361]
* Avoids shard failures when performing bbox filter on coordinate
maps {pull}19548[#19548]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasneirynck I think bbox a short form of "geo bounding box" per (https://www.elastic.co/guide/en/elasticsearch/reference/6.3/query-dsl-geo-bounding-box-query.html). If that's true, I think adding the full term might help with searchability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified its "geo bounding box" and will make the fix

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to start including changes related to docs, tests, dev environment, etc. in the release notes, then I think we should separate those things out entirely into a new section at the bottom. Perhaps Important Documentation and Developer changes or something like that.

While some folks are going to appreciate these items, most of the people reading the release notes don't care about them, and they shouldn't need to wade through them to figure out the changes in the release that actually matter for production deploys. Plus, they're currently listed as bugs, which isn't accurate anyway.

I'm about to go on vacation, so don't block on me giving an LGTM.

@lcawl
Copy link
Contributor

lcawl commented Jul 20, 2018

I like that suggestion too!

@gchaps gchaps requested review from rhoboat and tylersmalley and removed request for rhoboat July 20, 2018 15:29
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gchaps gchaps merged commit f481891 into elastic:6.3 Jul 20, 2018
@gchaps gchaps deleted the docs/6.3.2_release_notes branch July 20, 2018 22:55
@tylersmalley
Copy link
Contributor

screen shot 2018-07-20 at 3 52 06 pm

gchaps added a commit that referenced this pull request Jul 21, 2018
* [DOCS] Release Notes for 6.3.2

* [DOCS] Clarified bbox in Release Notes

* [DOCS] Created section for Important Notes]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants