Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Fixes the Copy Post Url link #54831

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Jan 14, 2020

Summary

Fixes #53967

This fixes the Copy POST URL button for exporting a workpad to a PDF.

The code to generate the PDF was changed to post the data as a POST body, to prevent potential issues with query params being too long, but it ended up truncating this url.

So, this PR brings back the correct functionality of the Copy POST URL button to include a URL + the required query params. The create pdf will still do the post + post body.

@crob611 crob611 added review release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.6.0 v7.5.2 labels Jan 14, 2020
@crob611 crob611 requested a review from a team as a code owner January 14, 2020 22:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- is it possible to get a functional test (or just testing in general) for something like this? I know you're wanting to get to this in soon so maybe a follow-up PR?

@crob611
Copy link
Contributor Author

crob611 commented Jan 15, 2020

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Jan 15, 2020

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Jan 15, 2020

@poffdeluxe Yeah, I'll make a test for this. Looks l'll miss the first build due to not passing CI, so I'll go ahead and add that in this PR

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe
Copy link
Contributor

Tests look good! Hooray tests! 🎉🎉🎉

@crob611 crob611 merged commit 78ec55e into elastic:master Jan 16, 2020
@crob611 crob611 added the v7.7.0 label Jan 16, 2020
crob611 pushed a commit to crob611/kibana that referenced this pull request Jan 16, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>
crob611 pushed a commit to crob611/kibana that referenced this pull request Jan 16, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>
crob611 pushed a commit to crob611/kibana that referenced this pull request Jan 16, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>
@bhavyarm
Copy link
Contributor

bhavyarm commented Jan 16, 2020

@crob611 this won't make 7.5.2 as we already have BC1 and this isn't a blocker. Thanks! cc @LeeDr

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 17, 2020
…t-of-legacy

* 'master' of github.com:elastic/kibana: (142 commits)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  [Maps] Support styles on agg fields with _of_ in name (elastic#54965)
  Remove xpack_main requirement, it's no longer in use (elastic#55060)
  Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866)
  first rule cuts (elastic#54990)
  [DOCS] Adds geocentroid note to coordinate map (elastic#54389)
  [Canvas] Fixes the Copy Post Url link (elastic#54831)
  Fixes bugs with full screen filters (elastic#54792)
  [ML] Fix decoding in the URL state  (elastic#54915)
  Remove redundant `x-pack/typings`. (elastic#55042)
  [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules
  Generate legacy vars when rendering all applications (elastic#54768)
  ...

# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
crob611 pushed a commit that referenced this pull request Jan 17, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
crob611 pushed a commit that referenced this pull request Jan 17, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
* Fixes the Copy Post Url link

* Adds tests

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. release_note:fix review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.2 v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy post URL on canvas reporting is missing details necessary for successful reporting
5 participants