Remove redundant x-pack/typings
.
#55042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we can remove
x-pack/typings
and rely ontypings
from the root with the exception ofjest
(we still use expect.js in functional tests and jest types conflict with it).The motivation behind this change is that type check started to fail on
x-pack/test
project when we started to use our own typings for EUI in NP x-pack plugins: #53880 (comment). Likely because we import something from NP plugins inx-pack/tests
, thanks to @mistic for debugging this!But irrespective to the reason behind the change it seems reasonable to me unless I'm missing something.
/cc @mistic