-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to opt out from sub url tracking #55672
Conversation
Pinging @elastic/kibana-platform (Team:Platform) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fixing the core API docs, try doing this:
$ rm -rf target/
$ yarn build:types
And then run the check API / docs script.
@@ -25,6 +25,7 @@ export class UiNavLink { | |||
order = 0, | |||
url, | |||
subUrlBase, | |||
disableSubUrlTracking, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to add this to src/legacy/ui/ui_apps/ui_app.js
which is also a source of navLinks
@joshdover That did the trick, thanks 👍 |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for platform changes
…a into exclude-sub-url-tracking
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* introduce flag for disabling sub url tracking * re-generate documentation and extend ui_app * fix ui_nav_link test Co-authored-by: Elastic Machine <[email protected]>
* master: (21 commits) [SIEM][Detection Engine] critical blocker updates to latest ECS version [Monitoring] Fix inaccuracies in logstash pipeline listing metrics (elastic#55868) Resetting errors and removing duplicates (elastic#56054) Add flag to opt out from sub url tracking (elastic#55672) [SIEM][Detection Engine] critical bug, fixes duplicate tags [ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. (elastic#56113) [ML] Single Metric Viewer: Fix annnotations refresh. (elastic#56107) adapt ObjectToConfigAdapter.getFlattenedPaths to consider arrays as final values (elastic#56105) Add Appender.receiveAllLevels option to fix LegacyAppender (elastic#55752) [ML] Process delimited files like semi-structured text (elastic#56038) Charts plugin (combining ui/color_maps and EuiUtils) (elastic#55469) fix tutorial documentation (elastic#55996) [ML] Fix persist/restore of time/refreshInterval in data visualizer. (elastic#56122) [Index Management] Fix errors with validation (elastic#56072) [Index Management] Add try/catch when parsing index filter from URI (elastic#56051) [NP] add HTTP resources testing strategies (elastic#54908) [ML] Single Metric Viewer: Fix brush update on short recent timespans. (elastic#56125) [Uptime] Add timeout for slow process to skipped functional tests (elastic#56065) refactor (elastic#56121) Move tests in dashboard into appropriate folders (elastic#55304) ...
This PR adds an additional flag to legacy nav links
disableSubUrlTracking
that mark them to not be included in the auto-sub url tracking of the legacy chrome. This is the first step of incrementally moving this logic into the applications itself.You can test this by adding
disableSubUrlTracking: true
to one of the nav links specified insrc/legacy/core_plugins/kibana/index.js
The doc builder fails locally for me, that's why the API checker test fails:
node scripts/check_core_api_changes.js --accept