Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Add timeout for slow process to skipped functional tests #56065

Merged
merged 2 commits into from
Jan 28, 2020
Merged

[Uptime] Add timeout for slow process to skipped functional tests #56065

merged 2 commits into from
Jan 28, 2020

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Jan 27, 2020 •
edited
Loading

Summary

Fixes #54541.

You can review the results of 42 consecutive runs of these tests here.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added blocker test_ui_functional failed-test A test failure on a tracked branch, potentially flaky-test v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability skipped-test v7.7.0 v7.6.0 labels Jan 27, 2020
@justinkambic justinkambic self-assigned this Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@justinkambic justinkambic changed the title Reorder assertions in functional tests. [Uptime] Reorder assertions in skipped functional test Jan 27, 2020
@justinkambic justinkambic changed the title [Uptime] Reorder assertions in skipped functional test [Uptime] Add timeout for slow process to skipped functional tests Jan 27, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic marked this pull request as ready for review January 27, 2020 23:34
@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 27, 2020
andrewvc
andrewvc approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit a2a0f11 into elastic:master Jan 28, 2020
This was referenced Jan 28, 2020
Merged
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jan 28, 2020
@justinkambic
[Uptime] Add timeout for slow process to skipped functional tests (el…
704bf3e 
…astic#56065)

* Reorder assertions in functional tests.

* Introduce retry to functional tests.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jan 28, 2020
@justinkambic
[Uptime] Add timeout for slow process to skipped functional tests (el…
b827abc 
…astic#56065)

* Reorder assertions in functional tests.

* Introduce retry to functional tests.
justinkambic added a commit that referenced this pull request Jan 28, 2020
@justinkambic
[Uptime] Add timeout for slow process to skipped functional tests (#5…
b9e5b94 
…6065) (#56135)

* Reorder assertions in functional tests.

* Introduce retry to functional tests.
justinkambic added a commit that referenced this pull request Jan 28, 2020
@justinkambic
[Uptime] Add timeout for slow process to skipped functional tests (#5…
67343f7 
…6065) (#56136)

* Reorder assertions in functional tests.

* Introduce retry to functional tests.
@justinkambic
Copy link
Contributor Author

Backported to:

@justinkambic justinkambic deleted the uptime_fix-flaky-test-pagination branch January 28, 2020 16:14
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 28, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
100aa8d 
* master: (21 commits)
  [SIEM][Detection Engine] critical blocker updates to latest ECS version
  [Monitoring] Fix inaccuracies in logstash pipeline listing metrics (elastic#55868)
  Resetting errors and removing duplicates (elastic#56054)
  Add flag to opt out from sub url tracking (elastic#55672)
  [SIEM][Detection Engine] critical bug, fixes duplicate tags
  [ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. (elastic#56113)
  [ML] Single Metric Viewer: Fix annnotations refresh. (elastic#56107)
  adapt ObjectToConfigAdapter.getFlattenedPaths to consider arrays as final values (elastic#56105)
  Add Appender.receiveAllLevels option to fix LegacyAppender (elastic#55752)
  [ML] Process delimited files like semi-structured text (elastic#56038)
  Charts plugin (combining ui/color_maps and EuiUtils) (elastic#55469)
  fix tutorial documentation (elastic#55996)
  [ML] Fix persist/restore of time/refreshInterval in data visualizer. (elastic#56122)
  [Index Management] Fix errors with validation (elastic#56072)
  [Index Management] Add try/catch when parsing index filter from URI (elastic#56051)
  [NP] add HTTP resources testing strategies (elastic#54908)
  [ML] Single Metric Viewer: Fix brush update on short recent timespans. (elastic#56125)
  [Uptime] Add timeout for slow process to skipped functional tests (elastic#56065)
  refactor (elastic#56121)
  Move tests in dashboard into appropriate folders (elastic#55304)
  ...
This was referenced Jan 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

@shahzad31 shahzad31 Awaiting requested review from shahzad31

Assignees

@justinkambic justinkambic

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test_ui_functional v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@justinkambic @elasticmachine @kibanamachine @andrewvc