-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Refactor Network TLS to use Search Strategy #76241
[Security Solution] Refactor Network TLS to use Search Strategy #76241
Conversation
desc = 'desc', | ||
} | ||
|
||
export interface TlsSortField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I would like us to refactor SortField
to be like that below. Therefore, now we can have a generic/strict type if need it and TlsSortField can be replaced by SortField<TlsFields>
.
Does that make sense?
export interface SortField<Field = string> {
field: Field;
direction: Direction;
}
}; | ||
}; | ||
useEffect(() => { | ||
if (skip) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if I made a mistake with allHosts
query because I remove the skip. are we really using this skip attributes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing my mistake in #76252
…-tls-search-strategy # Conflicts: # x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts # x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/siem (Team:SIEM) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Checklist