Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor FirstLastSeenHost to use Search Strategy #76252

Merged
merged 5 commits into from
Aug 31, 2020
Merged

[Security Solution] Refactor FirstLastSeenHost to use Search Strategy #76252

merged 5 commits into from
Aug 31, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 30, 2020 •
edited
Loading

Summary

Refactor FirstLastSeenHost to use Search Strategy
image

Checklist

@patrykkopycinski patrykkopycinski requested review from a team as code owners August 30, 2020 19:46
@patrykkopycinski patrykkopycinski self-assigned this Aug 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

XavierM
XavierM reviewed Aug 31, 2020
View reviewed changes
x-pack/plugins/security_solution/public/hosts/components/first_last_seen_host/index.tsx
@@ -5,10 +5,9 @@
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -> you are already in the folder of hosts, so we do know that first_last_seen is for a host. Do you agree?

XavierM
XavierM approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, re-organizing the factory queries to a dedicated folder is nice ❤️ .

@XavierM XavierM mentioned this pull request Aug 31, 2020
Merged
2 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1930 +4 1926

async chunks size

id value diff baseline
securitySolution 9.5MB +6.5KB 9.5MB

distributable file count

id value diff baseline
total 44379 +9 44370

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 047c608 into elastic:master Aug 31, 2020
@patrykkopycinski patrykkopycinski deleted the feat/host-first-last-seen-search-strategy branch August 31, 2020 17:30
@patrykkopycinski patrykkopycinski mentioned this pull request Aug 31, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Aug 31, 2020
@patrykkopycinski
[Security Solution] Refactor FirstLastSeenHost to use Search Strategy (…
09d1b8a 
…elastic#76252)
patrykkopycinski added a commit that referenced this pull request Aug 31, 2020
@patrykkopycinski
[Security Solution] Refactor FirstLastSeenHost to use Search Strategy (…
dd61e4d 
…#76252) (#76314)
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @XavierM @MindyRS