[Search] Error notification alignment

[lizozom]

Summary

I've attached response files that can be used to mock each error type

This PR introduces explicit error types into the search service. The search service can now throw the following error types:

• AbortError if the request was canceled by the application or by calling cancelPending
• SearchTimeoutError if the request has timed out on the client or on the server.
• PainlessError if there's an painless script error inside the response
• Or if the error is unidentified, it throws the error as is.

It also introduces a showError function which handles showing toast messages for the errors thrown. This allows most applications to so something like this, without having to implement logic per specific error type (Dashboard for example doesn't use the default error handling and shows labels on individual panels instead).

data.search.search(...)
   .catchError((e: Error) => {
       data.search.showError(e);
   }

This logic is applied to discover, visualize and dashboard. In discover, it allowed deleting the old code handling of a PainlessError.

This PR also fixes #77579 by fixing how timeout subscriptions are removed.

How it looks

In Discover and Visualize

In dashboard

Most errors are shown inside individual panels, but timeout errors still show as a notification (once per session).

Dev Docs

This PR introduces explicit error types to the data.search service:

• AbortError if the request was canceled by the application or by calling cancelPending
• SearchTimeoutError if the request has timed out on the client or on the server.
• PainlessError if there's an painless script error inside the response
• Or if the error is unidentified, it throws the error as is.

The new showError function can be used with these errors, to show customized toast messages. Applications may choose to handle errors differently, however the SearchTimeoutError error notification will be shown regardless.

data.search.search(...)
   .catchError((e: Error) => {
       data.search.showError(e);
   }

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[lizozom]

@kibana-design changes are only deletion of a react component and it's css

[kertal]

Kibana App owned code LGTM 👍. like I mentioned, I will create an issue to improve the error message in Discover once this is merged.

[Dosant]

I tested basic "failed to fetch" error scenario in different apps by blocking requests. Seems good.
Didn't cover "upgrade to basic" scenario. (Didn't want to block, I need to dig into using those responses you've shared)

Thanks for addressing feedback suggestions.
Regarding react components as part of errors, I share @lukeelmers's point on it: #77788 (comment)

[lizozom]

@lukeelmers @Dosant @lukasolson I agree that having the notification code in the interceptor is not ideal and we can revisit this when unifying the search service and search interceptor code.

[gchaps]

There's a bit of repetition in the "Timed out" message. How about combining the title and the first sentence:

Title: Your query has timed out

Description: With our free Basic tier, your queries never time out.
Upgrade

[lizozom]

@elasticmachine merge upstream

[lizozom]

@elasticmachine merge upstream

[patrykkopycinski]

SIEM/Endpoint changes LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 47c452c

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
data	570	+3	567
discover	240	-11	251
total		-8

async chunks size

id	value	diff	baseline
discover	430.9KB	-7.5KB	438.5KB
visualize	271.2KB	-180.0B	271.4KB
total		-7.7KB

page load bundle size

id	value	diff	baseline
data	1.3MB	+8.9KB	1.3MB
dataEnhanced	34.1KB	-429.0B	34.5KB
expressions	204.2KB	+44.0B	204.1KB
total		+8.5KB

History

• 💚 Build #77190 succeeded 23f1603
• 💔 Build #77111 failed a9b9b7f
• 💔 Build #77053 failed 624f30f
• 💛 Build #76823 was flaky ecdeabf
• 💚 Build #76679 succeeded ecd5cce

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream