Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to specify request timeout per operation #567

Closed
cdahlqvist opened this issue Sep 5, 2018 · 2 comments
Closed

Ability to specify request timeout per operation #567

cdahlqvist opened this issue Sep 5, 2018 · 2 comments
Labels
:Config Config file format changes, new properties, ... enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution :Track Management New operations, changes in the track format, track download changes and the like
Milestone
2.x

Comments

@cdahlqvist
Copy link
Contributor

Currently Rally supports overriding the request timeout for all operations through custom client options. For complex tracks that mix different types of operations, it would be useful to be able to specify the request timeout per operations. This would make it possible to e.g. give a forcemerge operation a long timeout while keeping the default short for indexing and query requests.
@cdahlqvist cdahlqvist added the enhancement Improves the status quo label Sep 5, 2018
@cdahlqvist cdahlqvist added :Track Management New operations, changes in the track format, track download changes and the like :Config Config file format changes, new properties, ... labels Sep 5, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.2 milestone Sep 6, 2018
@danielmitterdorfer
Copy link
Member

Implementation note: This is the request_timeout parameter in the Elasticsearch client.

@ebadyano ebadyano modified the milestones: 1.0.2, 1.0.3 Nov 21, 2018
@danielmitterdorfer danielmitterdorfer removed their assignment Nov 27, 2018
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.0.3, 1.0.4 Jan 22, 2019
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.0.4, 1.1.0 Feb 20, 2019
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Mar 19, 2019
@danielmitterdorfer
Allow to override request timeout for force-merge
72dabee 
With this commit we add the ability to override the global request
timeout for the `force-merge` operation. This relates to elastic#567 but at the
moment we only implement it for `force-merge` and due to the fact that
we cannot solve this in a generic fashion for that operation anyway we
the current implementation is likely to stay even when we implement
full support in elastic#567. We intentionally add this new parameter without
documentation so we are free to change the parameter name later on.

Relates elastic#567
@danielmitterdorfer danielmitterdorfer mentioned this issue Mar 19, 2019
Merged
danielmitterdorfer added a commit that referenced this issue Mar 19, 2019
@danielmitterdorfer
Allow to override request timeout for force-merge
98bfa0b 
With this commit we add the ability to override the global request
timeout for the `force-merge` operation. This relates to #567 but at the
moment we only implement it for `force-merge` and due to the fact that
we cannot solve this in a generic fashion for that operation anyway we
the current implementation is likely to stay even when we implement
full support in #567. We intentionally add this new parameter without
documentation so we are free to change the parameter name later on.

Relates #567 
Relates #669
@dliappis dliappis modified the milestones: 1.1.0, 1.1.1 May 7, 2019
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.2.0, 1.2.1 Jun 7, 2019
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.3.0, 1.4.0 Sep 4, 2019
@danielmitterdorfer danielmitterdorfer added the help wanted We'd be happy about a community contribution label Sep 11, 2019
@henningandersen henningandersen mentioned this issue Nov 27, 2019
Merged
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.4.0, 1.4.1 Dec 3, 2019
@danielmitterdorfer danielmitterdorfer added the good first issue Small, contained changes that are good for newcomers label Jan 13, 2020
@ebadyano ebadyano self-assigned this Jan 17, 2020
@danielmitterdorfer danielmitterdorfer removed this from the 1.4.1 milestone Jan 23, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.x milestone Jan 23, 2020
@DJRickyB DJRickyB mentioned this issue Oct 5, 2020
Merged
hub-cap pushed a commit that referenced this issue Oct 27, 2020
@DJRickyB
Add support for custom headers and request-timeout (#1070)
90722ac 
Addresses #567 and #1000
@hub-cap
Copy link
Contributor

hub-cap commented Oct 27, 2020

closed by #1070

@hub-cap hub-cap closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Config Config file format changes, new properties, ... enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
6 participants
@hub-cap @danielmitterdorfer @dliappis @cdahlqvist @gingerwizard @ebadyano