Allow to override request timeout for force-merge #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add the ability to override the global request timeout for the `force-merge` operation. This relates to elastic#567 but at the moment we only implement it for `force-merge` and due to the fact that we cannot solve this in a generic fashion for that operation anyway we the current implementation is likely to stay even when we implement full support in elastic#567. We intentionally add this new parameter without documentation so we are free to change the parameter name later on. Relates elastic#567
danielmitterdorfer
added
enhancement
|
Thanks for the review! |
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 19, 2019
With this commit we pass the request timeout via the generic `params` dictionary to the optimize API (which we call via the client's raw transport API) instead of as a dedicated kw parameter (which is plain wrong). Relates #669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add the ability to override the global request
timeout for the
force-mergeoperation. This relates to #567 but at themoment we only implement it for
force-mergeand due to the fact thatwe cannot solve this in a generic fashion for that operation anyway we
the current implementation is likely to stay even when we implement
full support in #567. We intentionally add this new parameter without
documentation so we are free to change the parameter name later on.
Relates #567